Bug 190622

Summary:

AX: Certain tags should identify their context to iOS API

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
patch	none
patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
patch	none

chris fleizach

Reported 2018-10-16 09:29:21 PDT

Certain tags like <Code> can convey important context to screen readers. Use iOS API to convey that information

Attachments
patch (7.04 KB, patch) 2018-10-16 09:33 PDT, chris fleizach	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (3.36 MB, application/zip) 2018-10-16 11:18 PDT, EWS Watchlist	no flags	Details
patch (7.36 KB, patch) 2018-10-16 11:59 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (8.25 KB, patch) 2018-10-16 12:01 PDT, chris fleizach	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.31 MB, application/zip) 2018-10-16 17:22 PDT, EWS Watchlist	no flags	Details
patch (8.27 KB, patch) 2018-10-16 17:25 PDT, chris fleizach	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-10-16 09:29:38 PDT

<rdar://problem/45308194>

chris fleizach

Comment 2 2018-10-16 09:33:49 PDT

Created attachment 352462 [details] patch

EWS Watchlist

Comment 3 2018-10-16 11:18:41 PDT

Comment on attachment 352462 [details] patch Attachment 352462 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9623410 New failing tests: accessibility/ios-simulator/text-context-attributes.html

EWS Watchlist

Comment 4 2018-10-16 11:18:42 PDT

Created attachment 352476 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

chris fleizach

Comment 5 2018-10-16 11:59:18 PDT

Created attachment 352484 [details] patch

chris fleizach

Comment 6 2018-10-16 12:01:09 PDT

Created attachment 352485 [details] patch

EWS Watchlist

Comment 7 2018-10-16 17:22:40 PDT

Comment on attachment 352485 [details] patch Attachment 352485 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9628111 New failing tests: accessibility/ios-simulator/text-context-attributes.html

EWS Watchlist

Comment 8 2018-10-16 17:22:42 PDT

Created attachment 352524 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

chris fleizach

Comment 9 2018-10-16 17:25:11 PDT

Created attachment 352525 [details] patch

WebKit Commit Bot

Comment 10 2018-10-17 10:52:23 PDT

Comment on attachment 352525 [details] patch Clearing flags on attachment: 352525 Committed r237225: <https://trac.webkit.org/changeset/237225>

WebKit Commit Bot

Comment 11 2018-10-17 10:52:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.