Bug 190620

Summary: [Datalist] fast/forms/datalist/datalist-child-validation.html crashes with a debug assertion in isValidFormControlElement()
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: FormsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, commit-queue, jlewis3, jonlee, realdawei, rniwa, ryanhaddad, thorton, tsavell, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+
Rebase on trunk none

Wenson Hsieh
Reported 2018-10-16 08:40:26 PDT
Specifically, ASSERT(m_isValid == isValid()); When removing a form control element from a datalist, it seems we don't do the necessary bookkeeping to ensure that validity/willValidate is up to date.
Attachments
Patch (7.23 KB, patch)
2018-10-22 03:53 PDT, Wenson Hsieh 		rniwa: review+
DetailsFormatted DiffDiff
Rebase on trunk (7.17 KB, patch)
2019-03-01 20:21 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-16 08:41:03 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2018-10-16 09:06:53 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2018-10-22 03:53:54 PDT
Created attachment 352884 [details] Patch
Jon Lee
Comment 4 2019-03-01 16:10:35 PST
someone should review this...?
Jon Lee
Comment 5 2019-03-01 16:10:47 PST
rdar://problem/19226679
Wenson Hsieh
Comment 6 2019-03-01 20:21:28 PST
Created attachment 363403 [details] Rebase on trunk
WebKit Commit Bot
Comment 7 2019-03-01 22:09:36 PST
Comment on attachment 363403 [details] Rebase on trunk Clearing flags on attachment: 363403 Committed r242309: <https://trac.webkit.org/changeset/242309>
Note You need to log in before you can comment on or make changes to this bug.