Bug 190620 - [Datalist] fast/forms/datalist/datalist-child-validation.html crashes with a debug assertion in isValidFormControlElement()
Summary: [Datalist] fast/forms/datalist/datalist-child-validation.html crashes with a ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2018-10-16 08:40 PDT by Wenson Hsieh
Modified: 2019-03-01 22:26 PST (History)
12 users (show)

See Also:

Patch (7.23 KB, patch)
2018-10-22 03:53 PDT, Wenson Hsieh
rniwa: review+
Details | Formatted Diff | Diff
Rebase on trunk (7.17 KB, patch)
2019-03-01 20:21 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-10-16 08:40:26 PDT
Specifically, ASSERT(m_isValid == isValid());

When removing a form control element from a datalist, it seems we don't do the necessary bookkeeping to ensure that validity/willValidate is up to date.
Comment 1 Radar WebKit Bug Importer 2018-10-16 08:41:03 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2018-10-16 09:06:53 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2018-10-22 03:53:54 PDT
Created attachment 352884 [details]
Comment 4 Jon Lee 2019-03-01 16:10:35 PST
someone should review this...?
Comment 5 Jon Lee 2019-03-01 16:10:47 PST
Comment 6 Wenson Hsieh 2019-03-01 20:21:28 PST
Created attachment 363403 [details]
Rebase on trunk
Comment 7 WebKit Commit Bot 2019-03-01 22:09:36 PST
Comment on attachment 363403 [details]
Rebase on trunk

Clearing flags on attachment: 363403

Committed r242309: <https://trac.webkit.org/changeset/242309>