Bug 190608

Summary:

Add stub implementation for accessibility objects

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

WebCore Misc.

Assignee:

Don Olmstead <don.olmstead>

Status:

REOPENED

Severity:

Normal

CC:

aboxhall, achristensen, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, mcatanzaro, n_wang, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

190612

Bug Blocks:

189418

Attachments:

Description	Flags
Patch	none

Don Olmstead

Reported 2018-10-15 15:44:40 PDT

AccessibilityObjectWPE and AXObjectCacheWPE are just empty implementations

Attachments
Patch (9.16 KB, patch) 2018-10-15 16:12 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2018-10-15 16:12:40 PDT

Created attachment 352397 [details] Patch

Nan Wang

Comment 2 2018-10-15 17:26:44 PDT

Comment on attachment 352397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352397&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:109 > +#if !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)) Should wrap this into something for less confusion? !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)) Basically this is HAVE_ACCESSIBILITY minus PLATFORM(WPE)?

Don Olmstead

Comment 3 2018-10-15 17:45:29 PDT

(In reply to Nan Wang from comment #2) > Comment on attachment 352397 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352397&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:109 > > +#if !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)) > > Should wrap this into something for less confusion? > !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)) > Basically this is HAVE_ACCESSIBILITY minus PLATFORM(WPE)? I was more into having None implementations of things but rniwa wanted it more like this.

WebKit Commit Bot

Comment 4 2018-10-15 17:46:45 PDT

Comment on attachment 352397 [details] Patch Clearing flags on attachment: 352397 Committed r237162: <https://trac.webkit.org/changeset/237162>

WebKit Commit Bot

Comment 5 2018-10-15 17:46:47 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2018-10-15 17:47:32 PDT

<rdar://problem/45291448>

WebKit Commit Bot

Comment 7 2018-10-15 18:12:24 PDT

Re-opened since this is blocked by bug 190612

Alex Christensen

Comment 8 2018-10-15 18:18:47 PDT

Comment on attachment 352397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352397&action=review >>> Source/WebCore/accessibility/AXObjectCache.cpp:109 >>> +#if !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)) >> >> Should wrap this into something for less confusion? >> !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)) >> Basically this is HAVE_ACCESSIBILITY minus PLATFORM(WPE)? > > I was more into having None implementations of things but rniwa wanted it more like this. PLATFORM(IOS) || PLATFORM(MAC) == PLATFORM(COCOA) I also think this looks like a mess. Why not HAVE(ACCESSIBILITY)?

Ryosuke Niwa

Comment 9 2018-10-15 21:45:03 PDT

Yeah, let's add HAVE_ACCESSIBILITY or ENABLE_ACCESSIBILITY.

Michael Catanzaro

Comment 10 2018-10-16 10:20:44 PDT

There is already ENABLE_ACCESSIBILITY, so let's use that.

Note You need to log in before you can comment on or make changes to this bug.