Bug 190603

Summary: Support RTCConfiguration.certificates
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2018-10-15 14:38:30 PDT
Now that we have generateCertificate, let's allow RTCPeerConnection to use these.
Attachments
Patch (15.94 KB, patch)
2018-10-15 14:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (19.62 KB, patch)
2018-10-15 15:43 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.61 KB, patch)
2018-10-16 11:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-10-15 14:45:12 PDT
Created attachment 352384 [details] Patch
youenn fablet
Comment 2 2018-10-15 15:43:24 PDT
Created attachment 352393 [details] Patch
Eric Carlson
Comment 3 2018-10-16 11:14:46 PDT
Comment on attachment 352393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352393&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:303 > + exception = Exception { InvalidAccessError, "Certificate is expired"_s }; Nit: "Certificate has expired" would be better. > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:324 > return Exception { InvalidAccessError, "Bad Configuration Parameters" }; Nit: maybe "Invalid configuration parameters"?
youenn fablet
Comment 4 2018-10-16 11:24:34 PDT
Thanks for the review. > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:303 > > + exception = Exception { InvalidAccessError, "Certificate is expired"_s }; > > Nit: "Certificate has expired" would be better. OK > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:324 > > return Exception { InvalidAccessError, "Bad Configuration Parameters" }; > > Nit: maybe "Invalid configuration parameters"? Will do in another patch since that might need rebasing some other tests.
youenn fablet
Comment 5 2018-10-16 11:49:00 PDT
Created attachment 352481 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-10-16 14:01:22 PDT
Comment on attachment 352481 [details] Patch for landing Clearing flags on attachment: 352481 Committed r237202: <https://trac.webkit.org/changeset/237202>
WebKit Commit Bot
Comment 7 2018-10-16 14:01:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-16 14:03:20 PDT
<rdar://problem/45317733>
Note You need to log in before you can comment on or make changes to this bug.