Bug 190600

Summary: Remove unused parameters of WebPageGroupData
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, don.olmstead, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
cdumez: review+
Build fix
none
Build fix none

Alex Christensen
Reported 2018-10-15 13:57:22 PDT
Remove unused parameters of WebPageGroupData
Attachments
Patch (10.61 KB, patch)
2018-10-15 13:58 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Build fix (3.49 KB, patch)
2018-10-15 17:43 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Build fix (2.43 KB, patch)
2018-10-15 17:52 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-10-15 13:58:14 PDT
Created attachment 352373 [details] Patch
Chris Dumez
Comment 2 2018-10-15 14:07:12 PDT
Comment on attachment 352373 [details] Patch r=me if the bots are happy.
Alex Christensen
Comment 3 2018-10-15 14:34:06 PDT
http://trac.webkit.org/r237146
Radar WebKit Bug Importer
Comment 4 2018-10-15 14:35:37 PDT
<rdar://problem/45284661>
Don Olmstead
Comment 5 2018-10-15 17:31:44 PDT
WinCairo bot was not happy with this one.
Alex Christensen
Comment 6 2018-10-15 17:32:35 PDT
I'll take a look.
Alex Christensen
Comment 7 2018-10-15 17:39:21 PDT
https://trac.webkit.org/changeset/237161/webkit Could WinCairo stop using the entire concept of PageGroups? It's a legacy concept that we're trying to remove, so a new port should not have it.
Don Olmstead
Comment 8 2018-10-15 17:41:09 PDT
(In reply to Alex Christensen from comment #7) > https://trac.webkit.org/changeset/237161/webkit > Could WinCairo stop using the entire concept of PageGroups? It's a legacy > concept that we're trying to remove, so a new port should not have it. Sure. GTK ports were also affected though. You want to get stuff to green or do you want to start ripping out PageGroups?
Alex Christensen
Comment 9 2018-10-15 17:42:03 PDT
Get stuff to green for now. We unfortunately can't remove PageGroups right now because they're used by an Apple-internal client.
Don Olmstead
Comment 10 2018-10-15 17:43:04 PDT
Created attachment 352412 [details] Build fix Here's a build fix that should work. Your call if you want to land it.
Don Olmstead
Comment 11 2018-10-15 17:52:14 PDT
Created attachment 352414 [details] Build fix Now with GTK
Don Olmstead
Comment 12 2018-10-15 18:07:23 PDT
Ok so the GTK bots are borked because of that BUBBLE_WRAP dependency they added. Michael this patch work for you in GTK? I don't have a GTK build.
Alex Christensen
Comment 13 2018-10-15 18:13:45 PDT
Fixed GTK in 237165 Fixed API tests in r237167
Note You need to log in before you can comment on or make changes to this bug.