Bug 190591

Summary: Remove StorageProcess leftover
Product: WebKit Reporter: Patrick Griffis <pgriffis>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, mcatanzaro, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Remove StorageProcess leftover
none
Remove StorageProcess leftovers
none
Remove StorageProcess leftovers none

Patrick Griffis
Reported 2018-10-15 10:35:02 PDT
Remove StorageProcess leftover
Attachments
Patch (482 bytes, patch)
2018-10-15 10:35 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Remove StorageProcess leftover (1.20 KB, patch)
2018-10-15 10:41 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Remove StorageProcess leftovers (3.43 KB, patch)
2018-10-15 12:30 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Remove StorageProcess leftovers (4.78 KB, patch)
2018-10-15 13:55 PDT, Patrick Griffis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Patrick Griffis
Comment 1 2018-10-15 10:35:10 PDT
Created attachment 352340 [details] Patch
Patrick Griffis
Comment 2 2018-10-15 10:41:47 PDT
Created attachment 352341 [details] Remove StorageProcess leftover
Michael Catanzaro
Comment 3 2018-10-15 11:00:26 PDT
Comment on attachment 352341 [details] Remove StorageProcess leftover Looks like Mac builds are failing... it's still used in ChildProcessMac.mm and ProcessLauncherMac.mm.
Patrick Griffis
Comment 4 2018-10-15 12:30:49 PDT
Created attachment 352359 [details] Remove StorageProcess leftovers
Michael Catanzaro
Comment 5 2018-10-15 13:12:19 PDT
Comment on attachment 352359 [details] Remove StorageProcess leftovers Missing ChangeLog Also not sure why, because you clearly removed the enum value, but mac-32bit is unhappy for some reason: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource11-mm.mm:3: /Volumes/Data/EWS/WebKit/Source/WebKit/Shared/mac/ChildProcessMac.mm:279:13: error: enumeration value 'Storage' not handled in switch [-Werror,-Wswitch] switch (processType) { ^ /Volumes/Data/EWS/WebKit/Source/WebKit/Shared/mac/ChildProcessMac.mm:279:13: note: add missing switch cases switch (processType) { ^ 1 error generated.
Patrick Griffis
Comment 6 2018-10-15 13:55:07 PDT
Created attachment 352372 [details] Remove StorageProcess leftovers
Michael Catanzaro
Comment 7 2018-10-15 15:48:41 PDT
Comment on attachment 352372 [details] Remove StorageProcess leftovers Goodbye WebKitStorageProcess
Michael Catanzaro
Comment 8 2018-10-15 15:49:10 PDT
Comment on attachment 352372 [details] Remove StorageProcess leftovers Well technically this needs owner approval. Leaving cq+ for an owner.
WebKit Commit Bot
Comment 9 2018-10-15 16:19:00 PDT
Comment on attachment 352372 [details] Remove StorageProcess leftovers Clearing flags on attachment: 352372 Committed r237154: <https://trac.webkit.org/changeset/237154>
WebKit Commit Bot
Comment 10 2018-10-15 16:19:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-10-15 16:19:21 PDT
<rdar://problem/45288591>
Note You need to log in before you can comment on or make changes to this bug.