Bug 190576

Summary:

[GStreamer] fast/mediastream/get-user-media-device-id.html failing

Product:

WebKit

Reporter:

Claudio Saavedra <csaavedra>

Component:

WPE WebKit

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboya, alex, annulen, bugs-noreply, calvaris, dpino, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, lmoura, philipj, pnormand, ryuan.choi, sergio, tommyw, tsaunier

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=210926

Attachments:

Description	Flags
Patch	none
Patch	calvaris: review+

Description Claudio Saavedra 2018-10-15 05:24:52 PDT

Since https://trac.webkit.org/changeset/236877/webkit this test is failing in GTK and WPE. This is MediaStream related.

Comment 1 Philippe Normand 2020-04-29 10:25:05 PDT

Created attachment 397976 [details]
Patch

Comment 2 Philippe Normand 2020-04-29 10:30:56 PDT

Created attachment 397977 [details]
Patch

Comment 3 Philippe Normand 2020-04-29 10:33:14 PDT

*** Bug 205930 has been marked as a duplicate of this bug. ***

Comment 4 Philippe Normand 2020-04-29 10:34:50 PDT

*** Bug 210337 has been marked as a duplicate of this bug. ***

Comment 5 Philippe Normand 2020-04-29 10:35:48 PDT

*** Bug 206149 has been marked as a duplicate of this bug. ***

Comment 6 Philippe Normand 2020-04-29 10:36:09 PDT

*** Bug 192886 has been marked as a duplicate of this bug. ***

Comment 7 Philippe Normand 2020-04-29 10:36:29 PDT

*** Bug 210843 has been marked as a duplicate of this bug. ***

Comment 8 Xabier Rodríguez Calvar 2020-04-29 23:20:05 PDT

Comment on attachment 397977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397977&action=review

> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp:102
> +        auto sample = adoptGRef(gst_sample_new(buffer, caps.get(), nullptr, nullptr));

Buffer seems to be leaking here as gst_sample_new takes it as [transfer none] and it is not adopted to a GRefPtr above.

Comment 9 Philippe Normand 2020-04-30 01:12:18 PDT

Committed r260937: <https://trac.webkit.org/changeset/260937>

Comment 10 Philippe Normand 2020-04-30 01:12:52 PDT

Comment on attachment 397977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397977&action=review

>> Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp:102
>> +        auto sample = adoptGRef(gst_sample_new(buffer, caps.get(), nullptr, nullptr));
> 
> Buffer seems to be leaking here as gst_sample_new takes it as [transfer none] and it is not adopted to a GRefPtr above.

Oops indeed. Thanks for the review!