Bug 190544

Summary: Perf dashboard: add a test for aggregating subtests without a matching metric in /api/report
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, keith_miller, rniwa, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds tests
none
Patch for landing none

Ryosuke Niwa
Reported 2018-10-12 15:47:02 PDT
Add a test for /api/report to aggregate subtests one of which is missing the matching metric. The aggregator should simply skip that subtest.
Attachments
Adds tests (10.49 KB, patch)
2018-10-12 15:56 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.35 KB, patch)
2018-10-12 16:07 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-10-12 15:56:46 PDT
Created attachment 352222 [details] Adds tests
Keith Miller
Comment 2 2018-10-12 15:58:00 PDT
Comment on attachment 352222 [details] Adds tests rs=me.
dewei_zhu
Comment 3 2018-10-12 16:01:38 PDT
Comment on attachment 352222 [details] Adds tests View in context: https://bugs.webkit.org/attachment.cgi?id=352222&action=review > Websites/perf.webkit.org/server-tests/api-report-tests.js:619 > + "DummyBenchmark": { Not important, this indentation doesn't seem to be consistent with others.
dewei_zhu
Comment 4 2018-10-12 16:01:57 PDT
Looks good to me.
Ryosuke Niwa
Comment 5 2018-10-12 16:03:42 PDT
(In reply to dewei_zhu from comment #3) > Comment on attachment 352222 [details] > Adds tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352222&action=review > > > Websites/perf.webkit.org/server-tests/api-report-tests.js:619 > > + "DummyBenchmark": { > > Not important, this indentation doesn't seem to be consistent with others. Oh good catch. I don't know what happened there. Fixed!
dewei_zhu
Comment 6 2018-10-12 16:04:49 PDT
Comment on attachment 352222 [details] Adds tests View in context: https://bugs.webkit.org/attachment.cgi?id=352222&action=review > Websites/perf.webkit.org/server-tests/api-report-tests.js:670 > + "DummyBenchmark": { Ditto here.
Ryosuke Niwa
Comment 7 2018-10-12 16:07:04 PDT
Created attachment 352227 [details] Patch for landing
Ryosuke Niwa
Comment 8 2018-10-12 16:10:42 PDT
Comment on attachment 352227 [details] Patch for landing Clearing flags on attachment: 352227 Committed r237086: <https://trac.webkit.org/changeset/237086>
Ryosuke Niwa
Comment 9 2018-10-12 16:10:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-10-12 16:11:41 PDT
<rdar://problem/45240758>
Note You need to log in before you can comment on or make changes to this bug.