Bug 190533

Summary: Use downcast for use of RealtimeMediaSource in LibWebRTCMediaEndpoint
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2018-10-12 13:14:20 PDT
Use downcast for use of RealtimeMediaSource in LibWebRTCMediaEndpoint
Attachments
Patch (5.07 KB, patch)
2018-10-12 13:17 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2018-10-12 13:44 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-10-12 13:17:27 PDT
Created attachment 352194 [details] Patch
EWS Watchlist
Comment 2 2018-10-12 13:19:59 PDT
Attachment 352194 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:165: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:166: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
youenn fablet
Comment 3 2018-10-12 13:44:42 PDT
Created attachment 352196 [details] Patch
EWS Watchlist
Comment 4 2018-10-12 13:47:53 PDT
Attachment 352196 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:165: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/mediastream/RealtimeMediaSource.h:166: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 5 2018-10-12 14:37:08 PDT
Comment on attachment 352196 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-10-12 15:06:14 PDT
Comment on attachment 352196 [details] Patch Clearing flags on attachment: 352196 Committed r237082: <https://trac.webkit.org/changeset/237082>
WebKit Commit Bot
Comment 7 2018-10-12 15:06:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-12 15:07:25 PDT
<rdar://problem/45238780>
Note You need to log in before you can comment on or make changes to this bug.