Bug 19051

Summary:

REGRESSION (r33447): Assertion in JSDebugServer::removeListener when closing tab with Inspector open

Product:

WebKit

Reporter:

Matt Lilek <dev+webkit>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, eric

Priority:

Keywords:

Regression

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch with ChangeLog	hyatt: review+

Matt Lilek

Reported 2008-05-14 12:03:32 PDT

Closing a tab in r33447 crashes because of: <http://trac.webkit.org/browser/trunk/WebCore/page/JavaScriptDebugServer.cpp#L109> ARGUMENT BAD: page, page (/Users/matt/Code/WebKit/WebCore/page/JavaScriptDebugServer.cpp:109 void WebCore::JavaScriptDebugServer::removeListener(WebCore::JavaScriptDebugListener*, WebCore::Page*)) Thread 0 Crashed: 0 com.apple.WebCore 0x02a20e42 WebCore::JavaScriptDebugServer::removeListener(WebCore::JavaScriptDebugListener*, WebCore::Page*) + 78 (JavaScriptDebugServer.cpp:109) 1 com.apple.WebCore 0x025dc3bc WebCore::InspectorController::stopDebugging() + 38 (InspectorController.cpp:2076) 2 com.apple.WebCore 0x025e098d WebCore::InspectorController::~InspectorController() + 347 3 com.apple.WebCore 0x0271531e void WTF::deleteOwnedPtr<WebCore::InspectorController>(WebCore::InspectorController*) + 30 (OwnPtr.h:52) 4 com.apple.WebCore 0x02715333 WTF::OwnPtr<WebCore::InspectorController>::~OwnPtr() + 19 5 com.apple.WebCore 0x02714410 WebCore::Page::~Page() + 462 6 com.apple.WebKit 0x0022ff7d -[WebView(WebPrivate) _close] + 475 (WebView.mm:729)

Attachments
patch with ChangeLog (6.67 KB, patch) 2008-05-14 12:54 PDT, Adam Roben (:aroben)	hyatt: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2008-05-14 12:54:34 PDT

Created attachment 21131 [details] patch with ChangeLog

Dave Hyatt

Comment 2 2008-05-14 12:57:30 PDT

Comment on attachment 21131 [details] patch with ChangeLog r=me

Eric Seidel (no email)

Comment 3 2008-05-14 13:02:07 PDT

*** Bug 19056 has been marked as a duplicate of this bug. ***

Adam Roben (:aroben)

Comment 4 2008-05-14 13:06:46 PDT

Committed in r33450.

Note You need to log in before you can comment on or make changes to this bug.