Bug 190495

Summary:

Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for web content)

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, simon.fraser, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Description Tim Horton 2018-10-11 15:20:17 PDT

Hardware keyboard arrow keys/spacebar don't scroll PDFs (works for web content)

Comment 1 Tim Horton 2018-10-11 15:21:57 PDT

Created attachment 352091 [details]
Patch

Comment 2 Tim Horton 2018-10-11 15:21:59 PDT

<rdar://problem/22734616>

Comment 3 Tim Horton 2018-10-11 15:22:31 PDT

Comment on attachment 352091 [details]
Patch

The new files are missing...

Comment 4 Tim Horton 2018-10-11 15:23:10 PDT

Created attachment 352092 [details]
Patch

Comment 5 Andy Estes 2018-10-11 15:38:11 PDT

Comment on attachment 352092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352092&action=review

> Source/WebKit/UIProcess/ios/WKPDFView.mm:85
> +    ::WebEvent *webEvent = [[[WKWebEvent alloc] initWithEvent:event] autorelease];

auto webEvent = adoptNS(...?

Comment 6 Tim Horton 2018-10-11 15:59:00 PDT

Sure why not

Comment 7 Tim Horton 2018-10-11 16:02:34 PDT

Created attachment 352097 [details]
Patch

Comment 8 Tim Horton 2018-10-11 16:03:44 PDT

Created attachment 352098 [details]
Patch

Comment 9 Tim Horton 2018-10-11 16:41:36 PDT

https://trac.webkit.org/changeset/237053/webkit