Bug 190486

Summary: [WTF] Semaphore.h conflicts with POSIX header
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Web Template FrameworkAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2018-10-11 14:23:59 PDT
In https://trac.webkit.org/changeset/236101/webkit Semaphore.h was added to WTF. This can conflict with the POSIX semaphore.h on file systems that are case-insensitive. Propose to rename it to WTFSemaphore which is a similar route to WTFString.
Attachments
Patch (12.46 KB, patch)
2018-10-11 14:40 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-10-11 14:40:26 PDT
Created attachment 352081 [details] Patch
Yusuke Suzuki
Comment 2 2018-10-11 15:10:24 PDT
Comment on attachment 352081 [details] Patch r=me
WebKit Commit Bot
Comment 3 2018-10-11 15:52:50 PDT
Comment on attachment 352081 [details] Patch Clearing flags on attachment: 352081 Committed r237052: <https://trac.webkit.org/changeset/237052>
WebKit Commit Bot
Comment 4 2018-10-11 15:52:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-10-11 15:54:03 PDT
<rdar://problem/45209633>
Note You need to log in before you can comment on or make changes to this bug.