Bug 190486

Summary:

[WTF] Semaphore.h conflicts with POSIX header

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Web Template Framework

Assignee:

Ross Kirsling <ross.kirsling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Don Olmstead 2018-10-11 14:23:59 PDT

In https://trac.webkit.org/changeset/236101/webkit Semaphore.h was added to WTF. This can conflict with the POSIX semaphore.h on file systems that are case-insensitive.

Propose to rename it to WTFSemaphore which is a similar route to WTFString.

Comment 1 Ross Kirsling 2018-10-11 14:40:26 PDT

Created attachment 352081 [details]
Patch

Comment 2 Yusuke Suzuki 2018-10-11 15:10:24 PDT

Comment on attachment 352081 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2018-10-11 15:52:50 PDT

Comment on attachment 352081 [details]
Patch

Clearing flags on attachment: 352081

Committed r237052: <https://trac.webkit.org/changeset/237052>

Comment 4 WebKit Commit Bot 2018-10-11 15:52:52 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2018-10-11 15:54:03 PDT

<rdar://problem/45209633>