Bug 190477

Summary: Add PLATFORM(IOS_FAMILY) and OS(IOS_FAMILY)
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Web Template FrameworkAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, mitz, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch thorton: review+

Alexey Proskuryakov
Reported 2018-10-11 13:08:51 PDT
Currently, PLATFORM(IOS) and OS(IOS) are true when building for any TARGET_OS_IPHONE target, which is quite confusing. Add a better named alternative, as a first step towards mass replacing PLATFORM(IOS). Can't so it all at once because of dependencies in other source repositories.
Attachments
proposed patch (5.90 KB, patch)
2018-10-11 13:12 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-10-11 13:12:26 PDT
Created attachment 352068 [details] proposed patch
Tim Horton
Comment 2 2018-10-11 13:13:06 PDT
Earlier suggestion was PLATFORM(COCOA_TOUCH). Technically that does include all UIKitty platforms even if they don't have touch proper.
Alexey Proskuryakov
Comment 3 2018-10-11 13:29:08 PDT
Do you like that earlier suggestion more? I do not.
Tim Horton
Comment 4 2018-10-11 15:47:27 PDT
Comment on attachment 352068 [details] proposed patch I'd like to hear more r+ of the name first, but the approach is fine
mitz
Comment 5 2018-10-11 16:15:33 PDT
Of the names proposed so far, I prefer the one in the patch.
Alexey Proskuryakov
Comment 6 2018-10-12 09:58:40 PDT
Committed http://trac.webkit.org/r237069
Radar WebKit Bug Importer
Comment 7 2018-10-12 09:59:21 PDT
<rdar://problem/45228899>
Note You need to log in before you can comment on or make changes to this bug.