Bug 190464

Summary: [GStreamer][MSE] Fix height calculation for streams with source aspect ratio
Product: WebKit Reporter: Enrique Ocaña <eocanha>
Component: MediaAssignee: Enrique Ocaña <eocanha>
Status: RESOLVED FIXED    
Severity: Normal CC: bandou.yacine, calvaris, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Enrique Ocaña 2018-10-11 03:02:39 PDT 
(At least) MPEG-DASH videos with Screen Aspect Ration (SAR) different than 1:1 are wrongly displayed when played with dash.js 2.9.0. The code that computes width/height on MSE is applying the SAR correction inversely. The actual result is a back and forth aspect switch between what dash.js (properly) computes as video resolution and what MSE (wrongly) computes as video resolution. For instance, in a video hacked to have SAR 2:1 (so it should have twice its normal width) the video is displayed with double-width, then half-width, then double, etc. Note that the video has double-width when the MPEG-DASH URL is played using a standalone gst-play-1.0 player.
Comment 1 Enrique Ocaña 2018-10-11 03:10:18 PDT 
Created attachment 352032 [details]
Patch
Comment 2 WebKit Commit Bot 2018-10-11 04:10:21 PDT 
Comment on attachment 352032 [details]
Patch

Clearing flags on attachment: 352032

Committed r237033: <https://trac.webkit.org/changeset/237033>
Comment 3 WebKit Commit Bot 2018-10-11 04:10:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-10-11 04:11:31 PDT 
<rdar://problem/45189891>
Comment 5 Philippe Normand 2018-10-11 04:44:59 PDT 
*** Bug 183591 has been marked as a duplicate of this bug. ***
Comment 6 Yacine Bandou 2018-10-11 05:26:59 PDT 
(In reply to Philippe Normand from comment #5)
> *** Bug 183591 has been marked as a duplicate of this bug. ***

I think that should be the opposite ;)