| Summary: | Hide RenderLayer z-order and normal flow lists behind iterators | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, sabouhallawa, simon.fraser, thorton, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2018-10-10 20:05:19 PDT
Created attachment 352011 [details]
Patch
Comment on attachment 352011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352011&action=review > Source/WebCore/rendering/RenderLayer.h:373 > + iterator begin() { return m_layerList ? m_layerList->begin() : nullptr; } > + iterator end() { return m_layerList ? m_layerList->end() : nullptr; } > + > + reverse_iterator rbegin() { return reverse_iterator(end()); } > + reverse_iterator rend() { return reverse_iterator(begin()); } It's a bit odd that a class named Iterator has functions like these. LayerIterable? LayerList? (In reply to Simon Fraser (smfr) from comment #3) > LayerIterable? LayerList? LayerList is fine. |