| Summary: | Web Inspector: Network: more aggressively snap timing blocks together | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, mattbaker, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Devin Rousso
2018-10-10 13:42:03 PDT
(In reply to Devin Rousso from comment #0) > Right now, we don't do any snapping of timing phases, such that if one is > close enough to the other we just join them. We currently "rely" on pixel > rounding to do this for us. We should more aggressively snap these phase > blocks together (e.g. if the difference is less than 2px just merge them). Nice. We do something similar when computing segments for rendering frame "bars". Created attachment 351990 [details] Patch This patch relies on changes from <https://webkit.org/b/189773>. I will upload a different version if that bug takes a while to land. Created attachment 352018 [details]
Patch
Rebase
Comment on attachment 352018 [details] Patch Clearing flags on attachment: 352018 Committed r237430: <https://trac.webkit.org/changeset/237430> All reviewed patches have been landed. Closing bug. |