Bug 190439

Summary: Web Inspector: Network: more aggressively snap timing blocks together
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-10-10 13:42:03 PDT
Right now, we don't do any snapping of timing phases, such that if one is close enough to the other we just join them. We currently "rely" on pixel rounding to do this for us. We should more aggressively snap these phase blocks together (e.g. if the difference is less than 2px just merge them).
Attachments
Patch (2.07 KB, patch)
2018-10-10 15:04 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.14 KB, patch)
2018-10-10 22:33 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2018-10-10 13:48:10 PDT
(In reply to Devin Rousso from comment #0) > Right now, we don't do any snapping of timing phases, such that if one is > close enough to the other we just join them. We currently "rely" on pixel > rounding to do this for us. We should more aggressively snap these phase > blocks together (e.g. if the difference is less than 2px just merge them). Nice. We do something similar when computing segments for rendering frame "bars".
Devin Rousso
Comment 2 2018-10-10 15:04:26 PDT
Created attachment 351990 [details] Patch This patch relies on changes from <https://webkit.org/b/189773>. I will upload a different version if that bug takes a while to land.
Devin Rousso
Comment 3 2018-10-10 22:33:23 PDT
Created attachment 352018 [details] Patch Rebase
WebKit Commit Bot
Comment 4 2018-10-25 15:57:52 PDT
Comment on attachment 352018 [details] Patch Clearing flags on attachment: 352018 Committed r237430: <https://trac.webkit.org/changeset/237430>
WebKit Commit Bot
Comment 5 2018-10-25 15:57:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-25 15:58:26 PDT
<rdar://problem/45570193>
Note You need to log in before you can comment on or make changes to this bug.