Bug 190430

Summary: build-webkit --inspector-frontend shouldn't have a nonzero exit code
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2018-10-10 10:47:30 PDT
build-webkit --inspector-frontend shouldn't have a nonzero exit code
Attachments
Patch (1.31 KB, patch)
2018-10-10 10:49 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-10-10 10:49:54 PDT
Created attachment 351970 [details] Patch
Ross Kirsling
Comment 2 2018-10-10 10:52:27 PDT
This has been busted forever, but I never took the time to investigate the cause until now. :P Success output before patch: > ** BUILD SUCCEEDED ** > > xcodebuild: error: invalid option '--inspector-frontend' Success output after patch: > ** BUILD SUCCEEDED ** > > > ==================================================================== > WebKit is now built (00m:05s). > To run Safari with this newly-built code, use the > "Tools/Scripts/run-safari" script. > ====================================================================
Blaze Burg
Comment 3 2018-10-10 11:01:01 PDT
Comment on attachment 351970 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2018-10-10 13:29:08 PDT
Comment on attachment 351970 [details] Patch Clearing flags on attachment: 351970 Committed r237015: <https://trac.webkit.org/changeset/237015>
WebKit Commit Bot
Comment 5 2018-10-10 13:29:10 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-10 13:30:27 PDT
<rdar://problem/45170865>
Note You need to log in before you can comment on or make changes to this bug.