| Summary: | New window event for wxWebKit | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Dunn <robin> | ||||||||
| Component: | WebKit wx | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | kevino | ||||||||
| Priority: | P2 | Keywords: | Wx | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Robin Dunn
2008-05-14 00:48:05 PDT
Created attachment 21120 [details]
patch for new window event
Created attachment 21121 [details]
patch for new window event
Comment on attachment 21121 [details]
patch for new window event
This looks good except for one important detail. When we implement DecidePolicy events, we need to handle the case in which they are ignored. In this case, if possible, I think we should restructure the code so that if the wxWebViewNewWindowEvent is not handled, we will return PolicyIgnore rather than PolicyUse. We should also offer a "Cancel" event like with BeforeLoad to allow the app to block certain URLs and let WebCore know that they were blocked.
Thanks for all your help! :)
Created attachment 29516 [details]
Updated patch
|