Bug 19043

Summary: New window event for wxWebKit
Product: WebKit Reporter: Robin Dunn <robin>
Component: WebKit wxAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: kevino
Priority: P2 Keywords: Wx
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
patch for new window event
patch for new window event
kevino: review-
Updated patch kevino: review+

Description Robin Dunn 2008-05-14 00:48:05 PDT
This patch adds sending of the new window event for wxWebKit
Comment 1 Robin Dunn 2008-05-14 00:48:57 PDT
Created attachment 21120 [details]
patch for new window event
Comment 2 Robin Dunn 2008-05-14 00:49:08 PDT
Created attachment 21121 [details]
patch for new window event
Comment 3 Kevin Ollivier 2008-05-28 13:43:09 PDT
Comment on attachment 21121 [details]
patch for new window event

This looks good except for one important detail. When we implement DecidePolicy events, we need to handle the case in which they are ignored. In this case, if possible, I think we should restructure the code so that if the wxWebViewNewWindowEvent is not handled, we will return PolicyIgnore rather than PolicyUse. We should also offer a "Cancel" event like with BeforeLoad to allow the app to block certain URLs and let WebCore know that they were blocked. 

Thanks for all your help! :)
Comment 4 Robin Dunn 2009-04-15 14:38:17 PDT
Created attachment 29516 [details]
Updated patch
Comment 5 Kevin Ollivier 2009-04-15 15:47:05 PDT
Landed in r42562, thanks!