Bug 19043

Summary: New window event for wxWebKit
Product: WebKit Reporter: Robin Dunn <robin>
Component: WebKit wxAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kevino
Priority: P2 Keywords: Wx
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch for new window event
none
patch for new window event
kevino: review-
Updated patch kevino: review+

Robin Dunn
Reported 2008-05-14 00:48:05 PDT
This patch adds sending of the new window event for wxWebKit
Attachments
patch for new window event (1.90 KB, patch)
2008-05-14 00:48 PDT, Robin Dunn 		no flags
DetailsFormatted DiffDiff
patch for new window event (1.90 KB, patch)
2008-05-14 00:49 PDT, Robin Dunn 		kevino: review-
DetailsFormatted DiffDiff
Updated patch (1.84 KB, patch)
2009-04-15 14:38 PDT, Robin Dunn 		kevino: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robin Dunn
Comment 1 2008-05-14 00:48:57 PDT
Created attachment 21120 [details] patch for new window event
Robin Dunn
Comment 2 2008-05-14 00:49:08 PDT
Created attachment 21121 [details] patch for new window event
Kevin Ollivier
Comment 3 2008-05-28 13:43:09 PDT
Comment on attachment 21121 [details] patch for new window event This looks good except for one important detail. When we implement DecidePolicy events, we need to handle the case in which they are ignored. In this case, if possible, I think we should restructure the code so that if the wxWebViewNewWindowEvent is not handled, we will return PolicyIgnore rather than PolicyUse. We should also offer a "Cancel" event like with BeforeLoad to allow the app to block certain URLs and let WebCore know that they were blocked. Thanks for all your help! :)
Robin Dunn
Comment 4 2009-04-15 14:38:17 PDT
Created attachment 29516 [details] Updated patch
Kevin Ollivier
Comment 5 2009-04-15 15:47:05 PDT
Landed in r42562, thanks!
Note You need to log in before you can comment on or make changes to this bug.