Bug 190420

Summary: Share more WKShareSheet code between macOS and iOS, and fix a few bugs
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews116 for mac-sierra
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2018-10-09 19:58:33 PDT
Share more WKShareSheet code between macOS and iOS, and fix a few bugs
Attachments
Patch (36.57 KB, patch)
2018-10-09 19:58 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (36.55 KB, patch)
2018-10-09 20:21 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.34 MB, application/zip)
2018-10-09 21:30 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews116 for mac-sierra (3.04 MB, application/zip)
2018-10-09 22:09 PDT, EWS Watchlist 		no flags
Details
Patch (38.40 KB, patch)
2018-10-09 22:15 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (38.47 KB, patch)
2018-10-10 00:05 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (38.46 KB, patch)
2018-10-10 11:34 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-10-09 19:58:53 PDT
Created attachment 351935 [details] Patch
Tim Horton
Comment 2 2018-10-09 20:21:20 PDT
Created attachment 351936 [details] Patch
EWS Watchlist
Comment 3 2018-10-09 21:30:09 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 4 2018-10-09 21:30:11 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 5 2018-10-09 22:09:26 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 6 2018-10-09 22:09:28 PDT Comment hidden (obsolete)
Tim Horton
Comment 7 2018-10-09 22:15:02 PDT
Created attachment 351944 [details] Patch
Tim Horton
Comment 8 2018-10-09 22:16:30 PDT
I forgot about legacy WebKit
Tim Horton
Comment 9 2018-10-10 00:05:13 PDT
And 32-bit.
Tim Horton
Comment 10 2018-10-10 00:05:30 PDT
Created attachment 351948 [details] Patch
Simon Fraser (smfr)
Comment 11 2018-10-10 11:25:02 PDT
Comment on attachment 351948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351948&action=review > Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:79 > + NSURL *url = (NSURL *)*data.url; I think I prefer data.url.value() to avoid too many splats.
Tim Horton
Comment 12 2018-10-10 11:34:16 PDT
Created attachment 351976 [details] Patch
WebKit Commit Bot
Comment 13 2018-10-10 12:05:11 PDT
Comment on attachment 351976 [details] Patch Clearing flags on attachment: 351976 Committed r237012: <https://trac.webkit.org/changeset/237012>
WebKit Commit Bot
Comment 14 2018-10-10 12:05:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2018-10-10 12:06:28 PDT
<rdar://problem/45168515>
Note You need to log in before you can comment on or make changes to this bug.