| Summary: | Performance dashboard should show added iterations due failed build requests. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | dewei_zhu | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dewei_zhu, lforschler, rniwa | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
dewei_zhu
2018-10-09 17:33:59 PDT
Created attachment 351929 [details]
Patch
Comment on attachment 351929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351929&action=review > Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:374 > + this.content('status-summary').innerHTML = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`; Let's store values in local variables first so that the template literal looks nicer. Have you landed this change?? Landed in https://trac.webkit.org/changeset/236997. Please don't forget to close bugs. You can use webkit-patch land to do that automatically. Thanks! I will use that script. |