Bug 190409

Summary: [WPE][GTK] Complex text crashes with harfbuzz 1.8.8
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, commit-queue, mcatanzaro, zan
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2018-10-09 13:24:15 PDT
From https://gitlab.gnome.org/GNOME/evolution/issues/157 We discovered that harfbuzz 1.8.8 breaks WebKit by changing the ownership semantics of hb_icu_get_unicode_funcs() from (transfer full) to (transfer none). Our code was actually expecting (transfer none), so it's not immediately clear to me why it's crashing now, but doesn't matter as per Behdad: "Please just remove that line of code. hb-buffer comes up prepared with unicode-funcs these days (has had, for at least five years). Just removing that line completely results in better output." This should be covered by all our complex text tests if the bots were upgraded to the newer harfbuzz.
Attachments
Patch (2.18 KB, patch)
2018-10-09 13:27 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-10-09 13:27:56 PDT
Created attachment 351905 [details] Patch
WebKit Commit Bot
Comment 2 2018-10-09 14:59:20 PDT
Comment on attachment 351905 [details] Patch Clearing flags on attachment: 351905 Committed r236985: <https://trac.webkit.org/changeset/236985>
WebKit Commit Bot
Comment 3 2018-10-09 14:59:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.