Summary: | Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, justin_fan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 190305, 190325 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Devin Rousso
2018-10-09 10:30:08 PDT
Created attachment 351888 [details]
Patch
Comment on attachment 351888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review r=me > LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78 > + // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss Whats up with the "tick.sss" at the end of this sentence? Just a typo? Comment on attachment 351888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review >> LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78 >> + // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss > > Whats up with the "tick.sss" at the end of this sentence? Just a typo? That was my attempt at Cmd+S on the bus 😅 Created attachment 351893 [details]
Patch
Comment on attachment 351893 [details] Patch Clearing flags on attachment: 351893 Committed r236972: <https://trac.webkit.org/changeset/236972> All reviewed patches have been landed. Closing bug. |