Bug 190403

Summary: Web Inspector: REGRESSION: fix canvas test failures after r236952 and r236954
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, justin_fan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190305, 190325    
Bug Blocks:    
Attachments:
Description Flags
Patch
joepeck: review+
Patch none

Description Devin Rousso 2018-10-09 10:30:08 PDT
Related bugs:
 - <https://webkit.org/b/190305>
 - <https://webkit.org/b/190325>
Comment 1 Devin Rousso 2018-10-09 10:34:05 PDT
Created attachment 351888 [details]
Patch
Comment 2 Joseph Pecoraro 2018-10-09 10:40:04 PDT
Comment on attachment 351888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review

r=me

> LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78
> +                // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss

Whats up with the "tick.sss" at the end of this sentence? Just a typo?
Comment 3 Devin Rousso 2018-10-09 10:43:28 PDT
Comment on attachment 351888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351888&action=review

>> LayoutTests/inspector/canvas/resources/shaderProgram-utilities.js:78
>> +                // This can't use `awaitEvent` since the promise resolution happens on the next tick.sss
> 
> Whats up with the "tick.sss" at the end of this sentence? Just a typo?

That was my attempt at Cmd+S on the bus 😅
Comment 4 Devin Rousso 2018-10-09 10:44:01 PDT
Created attachment 351893 [details]
Patch
Comment 5 WebKit Commit Bot 2018-10-09 12:04:25 PDT
Comment on attachment 351893 [details]
Patch

Clearing flags on attachment: 351893

Committed r236972: <https://trac.webkit.org/changeset/236972>
Comment 6 WebKit Commit Bot 2018-10-09 12:04:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-09 12:07:35 PDT
<rdar://problem/45134558>