| Summary: | [WPE] Explicitly link against gmodule where used | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> | ||||
| Component: | WPE WebKit | Assignee: | Claudio Saavedra <csaavedra> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, commit-queue, mcatanzaro | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Claudio Saavedra
2018-10-09 08:16:07 PDT
Created attachment 351879 [details]
Patch
I ran into linking issues downstream because gmodule was not being pulled in, so let's add this. Not sure if it's needed for GTK+, but maybe yes. (In reply to Claudio Saavedra from comment #2) > I ran into linking issues downstream because gmodule was not being pulled > in, so let's add this. Not sure if it's needed for GTK+, but maybe yes. I think the linking error is noticeable more easily in the WPE port because GModule is used in JSC to load “libWPEInspectorResources.so”, which gets built first, but then it's used also in WebKit's “ModuleGlib.cpp” and “InjectedBundleGlib.cpp” so both ports en up using it. It could be that in the case of the GTK+ port some of the additional libraries used by the sources in the “WebKit/” subdir also use GModule, and that's why we don't see linker errors there. At any rate, the correct thing to do is explicitly adding the GModule flags obtained from pkg-config to the targets which use them, so let's land this (informal r+ here!) FWIW, the GTK+ port already has GModule in “Source/WebCore/PlatformGTK.cmake”, so no changes should be needed for the GTK+ port. Comment on attachment 351879 [details] Patch Clearing flags on attachment: 351879 Committed r236975: <https://trac.webkit.org/changeset/236975> All reviewed patches have been landed. Closing bug. |