Bug 190393

Summary:

ManifestGenerator shouldn't need more than 1GB of memory or run for 30 seconds

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, cdumez, dean_johnson, dewei_zhu, ggaren, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Improves the generator	koivisto: review+

Description Ryosuke Niwa 2018-10-08 22:50:23 PDT

In the internal instance of perf dashboard, manifest generation is taking 30s+ and requiring more than 1GB of RAM.
Improve ManifestGenerator to reduce the runtime & memory usage required.

Comment 1 Ryosuke Niwa 2018-10-08 23:27:09 PDT

Created attachment 351863 [details]
Improves the generator

Comment 2 Ryosuke Niwa 2018-10-08 23:28:35 PDT

Together with https://trac.webkit.org/changeset/236956, this patch should dramatically reduce the memory & CPU pressure on the internal perf dashboard.

Comment 3 dewei_zhu 2018-10-09 17:36:39 PDT

Looks good to me.

Comment 4 Ryosuke Niwa 2018-10-09 20:15:41 PDT

Committed r236996: <https://trac.webkit.org/changeset/236996>

Comment 5 Radar WebKit Bug Importer 2018-10-09 20:20:22 PDT

<rdar://problem/45149799>