Bug 190372

Summary: Web Inspector: replace Range.svg icon
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 189606    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch none

Devin Rousso
Reported 2018-10-08 14:36:58 PDT
.
Attachments
Patch (9.50 KB, patch)
2018-10-08 14:39 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (202.12 KB, image/png)
2018-10-08 14:40 PDT, Devin Rousso 		no flags
Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.19 MB, application/zip)
2018-10-08 15:53 PDT, EWS Watchlist 		no flags
Details
Patch (11.79 KB, patch)
2018-10-08 16:28 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-08 14:39:48 PDT
Created attachment 351816 [details] Patch
Devin Rousso
Comment 2 2018-10-08 14:40:14 PDT
Created attachment 351817 [details] [Image] After Patch is applied
Joseph Pecoraro
Comment 3 2018-10-08 14:49:14 PDT
Comment on attachment 351816 [details] Patch r=me
Joseph Pecoraro
Comment 4 2018-10-08 14:50:45 PDT
The border looks a little large compared to the large document icons. Likewise the background doesn't need to exist. I think I had a version of the icon with a better document-like background. Maybe we should use that for a RangeLarge.svg?
EWS Watchlist
Comment 5 2018-10-08 15:53:19 PDT
Comment on attachment 351816 [details] Patch Attachment 351816 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9495559 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html
EWS Watchlist
Comment 6 2018-10-08 15:53:21 PDT
Created attachment 351826 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Devin Rousso
Comment 7 2018-10-08 16:28:05 PDT
Created attachment 351832 [details] Patch Thanks to Joe for the icons :)
WebKit Commit Bot
Comment 8 2018-10-08 17:07:33 PDT
Comment on attachment 351832 [details] Patch Clearing flags on attachment: 351832 Committed r236950: <https://trac.webkit.org/changeset/236950>
WebKit Commit Bot
Comment 9 2018-10-08 17:07:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-10-08 17:08:23 PDT
<rdar://problem/45111288>
Note You need to log in before you can comment on or make changes to this bug.