Bug 190372 - Web Inspector: replace Range.svg icon
Summary: Web Inspector: replace Range.svg icon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 189606
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-08 14:36 PDT by Devin Rousso
Modified: 2018-10-08 17:08 PDT (History)
6 users (show)

See Also:


Attachments
Patch (9.50 KB, patch)
2018-10-08 14:39 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (202.12 KB, image/png)
2018-10-08 14:40 PDT, Devin Rousso
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.19 MB, application/zip)
2018-10-08 15:53 PDT, EWS Watchlist
no flags Details
Patch (11.79 KB, patch)
2018-10-08 16:28 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-08 14:36:58 PDT
.
Comment 1 Devin Rousso 2018-10-08 14:39:48 PDT
Created attachment 351816 [details]
Patch
Comment 2 Devin Rousso 2018-10-08 14:40:14 PDT
Created attachment 351817 [details]
[Image] After Patch is applied
Comment 3 Joseph Pecoraro 2018-10-08 14:49:14 PDT
Comment on attachment 351816 [details]
Patch

r=me
Comment 4 Joseph Pecoraro 2018-10-08 14:50:45 PDT
The border looks a little large compared to the large document icons. Likewise the background doesn't need to exist. I think I had a version of the icon with a better document-like background. Maybe we should use that for a RangeLarge.svg?
Comment 5 EWS Watchlist 2018-10-08 15:53:19 PDT
Comment on attachment 351816 [details]
Patch

Attachment 351816 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9495559

New failing tests:
css3/filters/backdrop/add-remove-add-backdrop-filter.html
Comment 6 EWS Watchlist 2018-10-08 15:53:21 PDT
Created attachment 351826 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Devin Rousso 2018-10-08 16:28:05 PDT
Created attachment 351832 [details]
Patch

Thanks to Joe for the icons :)
Comment 8 WebKit Commit Bot 2018-10-08 17:07:33 PDT
Comment on attachment 351832 [details]
Patch

Clearing flags on attachment: 351832

Committed r236950: <https://trac.webkit.org/changeset/236950>
Comment 9 WebKit Commit Bot 2018-10-08 17:07:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-10-08 17:08:23 PDT
<rdar://problem/45111288>