Bug 190347

Summary:

Move SystemFontDatabase to a file of its own

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, ggaren, mmaxfield, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	cdumez: review+, commit-queue: commit-queue-
patch	none
patch	none
patch	none
patch	none
patch	none
patch	commit-queue: commit-queue-
patch	none

Antti Koivisto

Reported 2018-10-08 05:38:01 PDT

From FontDescriptionCocoa

Attachments
patch (36.49 KB, patch) 2018-10-08 05:44 PDT, Antti Koivisto	cdumez: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
patch (35.95 KB, patch) 2018-10-08 09:53 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (35.99 KB, patch) 2018-10-08 10:03 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (35.93 KB, patch) 2018-10-08 10:06 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (39.47 KB, patch) 2018-10-08 10:22 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (39.66 KB, patch) 2018-10-08 10:47 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (39.67 KB, patch) 2018-10-08 11:30 PDT, Antti Koivisto	commit-queue: commit-queue-	Details Formatted Diff Diff
patch (39.57 KB, patch) 2018-10-08 12:53 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2018-10-08 05:44:02 PDT

Created attachment 351772 [details] patch

Chris Dumez

Comment 2 2018-10-08 09:12:06 PDT

Comment on attachment 351772 [details] patch rs=me

WebKit Commit Bot

Comment 3 2018-10-08 09:16:28 PDT

Comment on attachment 351772 [details] patch Rejecting attachment 351772 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 351772, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=351772&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=190347&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 351772 from bug 190347. Fetching: https://bugs.webkit.org/attachment.cgi?id=351772 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 7 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/SourcesCocoa.txt patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj Hunk #1 FAILED at 4811. Hunk #2 FAILED at 14548. Hunk #3 succeeded at 24028 (offset 5 lines). Hunk #4 succeeded at 27498 (offset 6 lines). 2 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp patching file Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp patching file Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.h patching file Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp Hunk #1 FAILED at 42. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9491130

Antti Koivisto

Comment 4 2018-10-08 09:53:58 PDT

Created attachment 351780 [details] patch

Antti Koivisto

Comment 5 2018-10-08 10:03:28 PDT

Created attachment 351783 [details] patch

Antti Koivisto

Comment 6 2018-10-08 10:06:25 PDT

Created attachment 351784 [details] patch

Antti Koivisto

Comment 7 2018-10-08 10:22:18 PDT

Created attachment 351788 [details] patch

Antti Koivisto

Comment 8 2018-10-08 10:47:38 PDT

Created attachment 351790 [details] patch

Antti Koivisto

Comment 9 2018-10-08 11:30:44 PDT

Created attachment 351796 [details] patch

WebKit Commit Bot

Comment 10 2018-10-08 12:22:34 PDT

Comment on attachment 351796 [details] patch Rejecting attachment 351796 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 351796, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/9493359

Antti Koivisto

Comment 11 2018-10-08 12:53:28 PDT

Created attachment 351807 [details] patch

WebKit Commit Bot

Comment 12 2018-10-08 13:37:34 PDT

Comment on attachment 351807 [details] patch Clearing flags on attachment: 351807 Committed r236938: <https://trac.webkit.org/changeset/236938>

WebKit Commit Bot

Comment 13 2018-10-08 13:37:35 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 14 2018-10-08 13:38:22 PDT

<rdar://problem/45102888>

Note You need to log in before you can comment on or make changes to this bug.