Bug 190342

Summary:

[Cocoa] [WK2] Add support for text alignment and text lists in font attributes

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

HTML Editing

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, ews-watchlist, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
First pass	none
Fix OpenSource iOS, macOS 10.12 builds	none
Fix OpenSource iOS build	none
Fix OpenSource iOS build (2)	ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-sierra	none
Patch	none
Rebase on trunk	none

Wenson Hsieh

Reported 2018-10-07 15:45:04 PDT

<rdar://problem/44767118>

Attachments
First pass (39.83 KB, patch) 2018-10-07 16:15 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Fix OpenSource iOS, macOS 10.12 builds (39.71 KB, patch) 2018-10-07 16:31 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Fix OpenSource iOS build (41.77 KB, patch) 2018-10-07 16:45 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Fix OpenSource iOS build (2) (39.76 KB, patch) 2018-10-07 16:54 PDT, Wenson Hsieh	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.48 MB, application/zip) 2018-10-07 17:42 PDT, EWS Watchlist	no flags	Details
Patch (47.88 KB, patch) 2018-10-07 19:56 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Rebase on trunk (47.72 KB, patch) 2018-10-08 18:30 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2018-10-07 16:15:49 PDT

Created attachment 351749 [details] First pass

Wenson Hsieh

Comment 2 2018-10-07 16:31:11 PDT

Created attachment 351750 [details] Fix OpenSource iOS, macOS 10.12 builds

Wenson Hsieh

Comment 3 2018-10-07 16:45:19 PDT

Created attachment 351752 [details] Fix OpenSource iOS build

Wenson Hsieh

Comment 4 2018-10-07 16:54:46 PDT

Created attachment 351753 [details] Fix OpenSource iOS build (2)

EWS Watchlist

Comment 5 2018-10-07 17:42:33 PDT Comment hidden (obsolete)

Comment on attachment 351753 [details] Fix OpenSource iOS build (2) Attachment 351753 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9485045 New failing tests: editing/mac/attributed-string/attributed-string-for-typing-with-color-filter.html editing/mac/attributed-string/attributed-string-for-typing.html

EWS Watchlist

Comment 6 2018-10-07 17:42:34 PDT Comment hidden (obsolete)

Created attachment 351755 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

Wenson Hsieh

Comment 7 2018-10-07 19:56:16 PDT

Created attachment 351758 [details] Patch

Tim Horton

Comment 8 2018-10-08 15:42:01 PDT

Comment on attachment 351758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351758&action=review > Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:110 > +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300) Are these exported? Should they be like all the other constants above (other than NSSuperscript)?

Wenson Hsieh

Comment 9 2018-10-08 15:56:04 PDT

Comment on attachment 351758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351758&action=review >> Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:110 >> +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300) > > Are these exported? Should they be like all the other constants above (other than NSSuperscript)? AFAICT, these are neither exported on iOS, nor on macOS prior to the High Sierra SDK :(

Wenson Hsieh

Comment 10 2018-10-08 18:30:25 PDT

Created attachment 351843 [details] Rebase on trunk

WebKit Commit Bot

Comment 11 2018-10-08 18:52:57 PDT

Comment on attachment 351843 [details] Rebase on trunk Clearing flags on attachment: 351843 Committed r236955: <https://trac.webkit.org/changeset/236955>

WebKit Commit Bot

Comment 12 2018-10-08 18:52:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.