| Summary: | [Cocoa] [WK2] Add support for text alignment and text lists in font attributes | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, ews-watchlist, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Wenson Hsieh
2018-10-07 15:45:04 PDT
Created attachment 351749 [details]
First pass
Created attachment 351750 [details]
Fix OpenSource iOS, macOS 10.12 builds
Created attachment 351752 [details]
Fix OpenSource iOS build
Created attachment 351753 [details]
Fix OpenSource iOS build (2)
Comment on attachment 351753 [details] Fix OpenSource iOS build (2) Attachment 351753 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9485045 New failing tests: editing/mac/attributed-string/attributed-string-for-typing-with-color-filter.html editing/mac/attributed-string/attributed-string-for-typing.html Created attachment 351755 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 351758 [details]
Patch
Comment on attachment 351758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351758&action=review > Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:110 > +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300) Are these exported? Should they be like all the other constants above (other than NSSuperscript)? Comment on attachment 351758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351758&action=review >> Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:110 >> +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300) > > Are these exported? Should they be like all the other constants above (other than NSSuperscript)? AFAICT, these are neither exported on iOS, nor on macOS prior to the High Sierra SDK :( Created attachment 351843 [details]
Rebase on trunk
Comment on attachment 351843 [details] Rebase on trunk Clearing flags on attachment: 351843 Committed r236955: <https://trac.webkit.org/changeset/236955> All reviewed patches have been landed. Closing bug. |