| Summary: | [Payment Request] Requests should be aborted after details settle when the user cancels | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, andersca, commit-queue, darin, sam, simon.fraser, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andy Estes
2018-10-06 17:22:24 PDT
Created attachment 351735 [details]
Patch
Created attachment 351736 [details]
Patch
Comment on attachment 351736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351736&action=review > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:668 > void PaymentRequest::whenDetailsSettled(std::function<void()>&& callback) Please use WTF::Function or WTF::CompletionHandler (In reply to Alex Christensen from comment #3) > Comment on attachment 351736 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351736&action=review > > > Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:668 > > void PaymentRequest::whenDetailsSettled(std::function<void()>&& callback) > > Please use WTF::Function or WTF::CompletionHandler Unable, unfortunately, because JSNativeStdFunction is a std::function. Comment on attachment 351736 [details] Patch Clearing flags on attachment: 351736 Committed r236922: <https://trac.webkit.org/changeset/236922> All reviewed patches have been landed. Closing bug. |