Bug 190330

Summary: Web Inspector: detail view is not re-shown after sorting the Network table
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190362    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2018-10-06 10:43:43 PDT 
* STEPS TO REPRODUCE
1. Inspect <https://apple.com>
2. Select the Network tab
3. Refresh the page
4. Select any resource to show it's detail view
5. Click the "Name" column header to change the sort
 => The same resource is still selected after re-sorting, but the detail view disappears, showing the Table selection
Comment 1 Radar WebKit Bug Importer 2018-10-08 08:57:19 PDT 
<rdar://problem/45089607>
Comment 2 Devin Rousso 2018-10-10 11:38:48 PDT 
Created attachment 351978 [details]
Patch
Comment 3 Matt Baker 2018-10-10 12:10:18 PDT 
Comment on attachment 351978 [details]
Patch

r-, as applying the patch causes an uncaught exception.

Steps to Reproduce:
1. Goto daringfireball.bnet
2. Network tab > select the first row
3. Sort the Name column

=> Uncaught exception:
TypeError:​ this._showDetailView is not a function. (In 'this._showDetailView(this._selectedObject)​', 'this._showDetailView' is undefined)​ (at NetworkTableContentView.js:​1681:​29)​
    _restoreSelectedRow @ NetworkTableContentView.js:​1681:​29
    _updateFilteredEntries @ NetworkTableContentView.js:​1552:​33
    tableSortChanged @ NetworkTableContentView.js:​337:​36
    sortOrder @ Table.js:​160:​50
    _handleHeaderCellClicked @ Table.js:​1308:​13
    _handleHeaderCellClicked @ [native code]​
Comment 4 Matt Baker 2018-10-10 12:10:51 PDT 
(In reply to Matt Baker from comment #3)
> Comment on attachment 351978 [details]
> Patch
> 
> r-, as applying the patch causes an uncaught exception.
> 
> Steps to Reproduce:
> 1. Goto daringfireball.bnet

Or even daringfireball.net
Comment 5 Devin Rousso 2018-10-10 13:37:15 PDT 
Whoops.  I uploaded a version of this that used changes from <https://webkit.org/b/189773>.  I'll reupload.
Comment 6 Devin Rousso 2018-10-10 22:34:26 PDT 
Created attachment 352019 [details]
Patch

Rebase
Comment 7 Matt Baker 2018-10-11 12:00:10 PDT 
Comment on attachment 352019 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2018-10-11 12:26:35 PDT 
Comment on attachment 352019 [details]
Patch

Clearing flags on attachment: 352019

Committed r237043: <https://trac.webkit.org/changeset/237043>
Comment 9 WebKit Commit Bot 2018-10-11 12:26:37 PDT 
All reviewed patches have been landed.  Closing bug.