Bug 190330

Summary: Web Inspector: detail view is not re-shown after sorting the Network table
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190362    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2018-10-06 10:43:43 PDT
* STEPS TO REPRODUCE 1. Inspect <https://apple.com> 2. Select the Network tab 3. Refresh the page 4. Select any resource to show it's detail view 5. Click the "Name" column header to change the sort => The same resource is still selected after re-sorting, but the detail view disappears, showing the Table selection
Attachments
Patch (1.30 KB, patch)
2018-10-10 11:38 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2018-10-10 22:34 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-08 08:57:19 PDT
<rdar://problem/45089607>
Devin Rousso
Comment 2 2018-10-10 11:38:48 PDT
Created attachment 351978 [details] Patch
Matt Baker
Comment 3 2018-10-10 12:10:18 PDT
Comment on attachment 351978 [details] Patch r-, as applying the patch causes an uncaught exception. Steps to Reproduce: 1. Goto daringfireball.bnet 2. Network tab > select the first row 3. Sort the Name column => Uncaught exception: TypeError:​ this._showDetailView is not a function. (In 'this._showDetailView(this._selectedObject)​', 'this._showDetailView' is undefined)​ (at NetworkTableContentView.js:​1681:​29)​ _restoreSelectedRow @ NetworkTableContentView.js:​1681:​29 _updateFilteredEntries @ NetworkTableContentView.js:​1552:​33 tableSortChanged @ NetworkTableContentView.js:​337:​36 sortOrder @ Table.js:​160:​50 _handleHeaderCellClicked @ Table.js:​1308:​13 _handleHeaderCellClicked @ [native code]​
Matt Baker
Comment 4 2018-10-10 12:10:51 PDT
(In reply to Matt Baker from comment #3) > Comment on attachment 351978 [details] > Patch > > r-, as applying the patch causes an uncaught exception. > > Steps to Reproduce: > 1. Goto daringfireball.bnet Or even daringfireball.net
Devin Rousso
Comment 5 2018-10-10 13:37:15 PDT
Whoops. I uploaded a version of this that used changes from <https://webkit.org/b/189773>. I'll reupload.
Devin Rousso
Comment 6 2018-10-10 22:34:26 PDT
Created attachment 352019 [details] Patch Rebase
Matt Baker
Comment 7 2018-10-11 12:00:10 PDT
Comment on attachment 352019 [details] Patch r=me
WebKit Commit Bot
Comment 8 2018-10-11 12:26:35 PDT
Comment on attachment 352019 [details] Patch Clearing flags on attachment: 352019 Committed r237043: <https://trac.webkit.org/changeset/237043>
WebKit Commit Bot
Comment 9 2018-10-11 12:26:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.