Bug 190326

Summary: [Xcode] Don’t install yasm and don’t compile it in iOS device builds
Product: WebKit Reporter: mitz
Component: WebRTCAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Skip install, and exclude all sources when building for a device none

mitz
Reported 2018-10-05 23:33:31 PDT
yasm is used for building vpx for macOS and the iOS Simulator, but it doesn’t need to be installed, and it’s not used when building for iOS devices. Patch forthcoming.
Attachments
Skip install, and exclude all sources when building for a device (1.88 KB, patch)
2018-10-05 23:35 PDT, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2018-10-05 23:35:18 PDT
Created attachment 351718 [details] Skip install, and exclude all sources when building for a device
youenn fablet
Comment 2 2018-10-06 07:14:45 PDT
Comment on attachment 351718 [details] Skip install, and exclude all sources when building for a device Thanks!
WebKit Commit Bot
Comment 3 2018-10-06 07:41:43 PDT
Comment on attachment 351718 [details] Skip install, and exclude all sources when building for a device Clearing flags on attachment: 351718 Committed r236896: <https://trac.webkit.org/changeset/236896>
WebKit Commit Bot
Comment 4 2018-10-06 07:41:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-10-06 07:42:26 PDT
<rdar://problem/45068117>
mitz
Comment 6 2018-10-06 09:00:21 PDT
(In reply to WebKit Commit Bot from comment #3) > Comment on attachment 351718 [details] > Skip install, and exclude all sources when building for a device > > Clearing flags on attachment: 351718 > > Committed r236896: <https://trac.webkit.org/changeset/236896> Fixed production builds for iOS devices in <https://trac.webkit.org/r236897>.
Note You need to log in before you can comment on or make changes to this bug.