| Summary: | Web Inspector: notify the frontend when a canvas has started recording via console.record | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Bug Depends on: | 190305 | ||||||||||||||
| Bug Blocks: | 173807, 175485 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Devin Rousso
2018-10-04 23:10:28 PDT
Created attachment 351663 [details]
Patch
Created attachment 351664 [details]
Patch
Comment on attachment 351664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351664&action=review This change looks fine (excepting that it doesn't apply to TOT). Please rebase. > Source/JavaScriptCore/inspector/protocol/Canvas.json:197 > + { "name": "fromConsole", "type": "boolean" } I'd prefer that this be "initiator" with enum { Frontend, ConsoleAPI }. Thinking ahead to the various ways console logs can be initiated, this seems more future-proof if we add other means to trigger this. I also just generically don't like adding boolean flags to the protocol. Comment on attachment 351664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351664&action=review (In reply to Brian Burg from comment #3) > This change looks fine (excepting that it doesn't apply to TOT). Please > rebase. It won't apply because it needs changes made in <https://webkit.org/b/190305> (which is blocking this one). >> Source/JavaScriptCore/inspector/protocol/Canvas.json:197 >> + { "name": "fromConsole", "type": "boolean" } > > I'd prefer that this be "initiator" with enum { Frontend, ConsoleAPI }. Thinking ahead to the various ways console logs can be initiated, this seems more future-proof if we add other means to trigger this. I also just generically don't like adding boolean flags to the protocol. Oooo I like it! Created attachment 351849 [details]
Patch
Comment on attachment 351849 [details] Patch Attachment 351849 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9499071 New failing tests: inspector/canvas/recording-bitmaprenderer.html Created attachment 351857 [details]
Archive of layout-test-results from ews117 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 351860 [details]
Patch
Comment on attachment 351860 [details]
Patch
r=me
Comment on attachment 351860 [details] Patch Clearing flags on attachment: 351860 Committed r237010: <https://trac.webkit.org/changeset/237010> All reviewed patches have been landed. Closing bug. |