Bug 190300

Summary: [WPE][JSC] Use Unified Sources for Platform-specific sources
Product: WebKit Reporter: Carlos Bentzen <cadubentzen>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aperez, bugs-noreply, cgarcia, commit-queue, fujii.hironori, mcatanzaro, ysuzuki, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Carlos Bentzen
Reported 2018-10-04 18:23:39 PDT
Currently the source files for the Remote Inspector in WPE are not integrated in Unified Sources, while the same sources for WebKitGTK+ are.
Attachments
Patch (5.75 KB, patch)
2018-10-04 18:44 PDT, Carlos Bentzen 		no flags
DetailsFormatted DiffDiff
Patch (5.75 KB, patch)
2018-10-04 18:48 PDT, Carlos Bentzen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Bentzen
Comment 1 2018-10-04 18:44:57 PDT
Created attachment 351646 [details] Patch
Carlos Bentzen
Comment 2 2018-10-04 18:48:22 PDT
Created attachment 351647 [details] Patch
Adrian Perez
Comment 3 2018-10-05 07:34:44 PDT
Comment on attachment 351647 [details] Patch Patch LGTM. We'll need a reviewer to set the r+, tho. Something that I am not particularly happy about is in general the unified sources mechanism (so this is nothing about your patch in particular, so no worries) because the way it works it basically breaks a lot of tooling: using YCM, code indexers, clangd/ccls, and many more “sees” the unified sources when what the tooling really needs to see is the original sources. But the build speed improvement is too good to let it go... ¬_¬
Yusuke Suzuki
Comment 4 2018-10-05 07:40:50 PDT
Comment on attachment 351647 [details] Patch r=me
WebKit Commit Bot
Comment 5 2018-10-05 08:06:30 PDT
Comment on attachment 351647 [details] Patch Clearing flags on attachment: 351647 Committed r236873: <https://trac.webkit.org/changeset/236873>
WebKit Commit Bot
Comment 6 2018-10-05 08:06:32 PDT
All reviewed patches have been landed. Closing bug.
Adrian Perez
Comment 7 2018-10-05 08:11:11 PDT
Thanks Yusuke for stopping by and checking the patch 🙌
Note You need to log in before you can comment on or make changes to this bug.