Bug 190293

Summary: Radar links should be clickable on bugs.webkit.org
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ddkilzer, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proof of concept
none
Patch none

Jer Noble
Reported 2018-10-04 14:16:05 PDT
Radar links should be clickable on bugs.webkit.org
Attachments
Proof of concept (3.20 KB, patch)
2018-10-04 14:18 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (5.15 KB, patch)
2018-10-05 15:52 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-10-04 14:16:31 PDT
<rdar://problem/45020184>
Jer Noble
Comment 2 2018-10-04 14:18:37 PDT
Created attachment 351631 [details] Proof of concept
Jer Noble
Comment 3 2018-10-05 15:52:44 PDT
Created attachment 351703 [details] Patch
WebKit Commit Bot
Comment 4 2018-10-05 17:02:56 PDT
Comment on attachment 351703 [details] Patch Clearing flags on attachment: 351703 Committed r236890: <https://trac.webkit.org/changeset/236890>
WebKit Commit Bot
Comment 5 2018-10-05 17:02:58 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2018-10-05 17:12:37 PDT
Comment on attachment 351703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351703&action=review > Websites/bugs.webkit.org/extensions/Radar/Extension.pm:41 > + push(@$regexes, { match => qr/\b(r[a]?dar:\/\/[[:word:]-.~&\/=%:,]*)([-.~&%=:,]?)\b/, replace => \&_replace_radar }); This doesn't cover radr:// links, which is a thing. That variant was used six times over the years in Bugzilla (probably accidentally), and radar:// was used 27 times :)
Alexey Proskuryakov
Comment 7 2018-10-05 17:15:44 PDT
Is this better than a simpler fix that you had in bug 136709 before?
Jer Noble
Comment 8 2018-10-05 18:27:38 PDT
As an extension, our changes here will never get blown away by changes to mainline Bugzilla, nor will we ever have to upstream this change. Basically, that was a hack, and this is the officially supported way of doing custom links fixation.
Alexey Proskuryakov
Comment 9 2018-10-06 15:27:07 PDT
Makes sense. I guess this needs to be tested in UAT now, and deployed. Please e-mail to sync up about that.
Alexey Proskuryakov
Comment 10 2019-05-12 14:38:30 PDT
*** Bug 136709 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.