| Summary: | Disable Options::useWebAssemblyFastMemory() on linux if ASAN signal handling is not disabled. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mcatanzaro, msaboff, saam, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2018-10-04 11:20:33 PDT
Created attachment 351607 [details]
proposed patch.
Comment on attachment 351607 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review r=me with comment. > Source/JavaScriptCore/runtime/Options.cpp:581 > + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); Do we actually need both or does ASAN work with just allow_user_segv_handler=1? Comment on attachment 351607 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review >> Source/JavaScriptCore/runtime/Options.cpp:581 >> + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); > > Do we actually need both or does ASAN work with just allow_user_segv_handler=1? We're checking for either here. Comment on attachment 351607 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review >>> Source/JavaScriptCore/runtime/Options.cpp:581 >>> + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); >> >> Do we actually need both or does ASAN work with just allow_user_segv_handler=1? > > We're checking for either here. Whoops, read that as &&. carry on! Thanks for the review. Landed in r236839: <http://trac.webkit.org/r236839>. |