Bug 190283

Summary: Disable Options::useWebAssemblyFastMemory() on linux if ASAN signal handling is not disabled.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mcatanzaro, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2018-10-04 11:20:33 PDT
Will also print a warning if we detect this condition.
Attachments
proposed patch. (2.75 KB, patch)
2018-10-04 11:30 PDT, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-04 11:28:05 PDT
<rdar://problem/45015752>
Mark Lam
Comment 2 2018-10-04 11:30:55 PDT
Created attachment 351607 [details] proposed patch.
Keith Miller
Comment 3 2018-10-04 12:14:58 PDT
Comment on attachment 351607 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review r=me with comment. > Source/JavaScriptCore/runtime/Options.cpp:581 > + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); Do we actually need both or does ASAN work with just allow_user_segv_handler=1?
Mark Lam
Comment 4 2018-10-04 12:17:40 PDT
Comment on attachment 351607 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review >> Source/JavaScriptCore/runtime/Options.cpp:581 >> + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); > > Do we actually need both or does ASAN work with just allow_user_segv_handler=1? We're checking for either here.
Keith Miller
Comment 5 2018-10-04 12:22:21 PDT
Comment on attachment 351607 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review >>> Source/JavaScriptCore/runtime/Options.cpp:581 >>> + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); >> >> Do we actually need both or does ASAN work with just allow_user_segv_handler=1? > > We're checking for either here. Whoops, read that as &&. carry on!
Mark Lam
Comment 6 2018-10-04 12:24:21 PDT
Thanks for the review. Landed in r236839: <http://trac.webkit.org/r236839>.
Note You need to log in before you can comment on or make changes to this bug.