Bug 190240

Summary: Clear m_pendingTargets in MutationObserver::takeRecords
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ajuma, cdumez, darin, dbates, esprehn+autocc, ews-watchlist, ggaren, joepeck, kangil.han, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup ggaren: review+

Ryosuke Niwa
Reported 2018-10-03 02:01:32 PDT
https://trac.webkit.org/r236781 delayed the clearing of m_pendingTargets until the end of microtask to avoid a race between JSMutationRecord's wrappers to be created and GC. Cleanup this code so that we don't have to delay the clearing until the end of Microtask.
Attachments
Cleanup (5.83 KB, patch)
2018-10-03 02:11 PDT, Ryosuke Niwa 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-10-03 02:11:29 PDT
Created attachment 351496 [details] Cleanup
Geoffrey Garen
Comment 2 2018-10-03 15:13:43 PDT
Comment on attachment 351496 [details] Cleanup r=me Can you add a bindings test for this? Here are two alternative names to consider: [ResultField=records] [ResultExtractor=result.records]
Radar WebKit Bug Importer
Comment 3 2018-10-03 20:51:01 PDT
<rdar://problem/44997466>
Ryosuke Niwa
Comment 4 2018-10-03 20:52:14 PDT
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 351496 [details] > Cleanup > > r=me > > Can you add a bindings test for this? Will do. > Here are two alternative names to consider: > > [ResultField=records] > [ResultExtractor=result.records] Will use ResultField.
Ryosuke Niwa
Comment 5 2018-10-03 20:55:14 PDT
Committed r236825: <https://trac.webkit.org/changeset/236825>
Note You need to log in before you can comment on or make changes to this bug.