Bug 190180

Summary:

Web Inspector: Dark Mode: wrong color used for "goto arrow" for selected DOM breakpoint tree element

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] DOM breakpoint tree element (selected)	none
[Image] DOM breakpoint tree element (hovered)	none
Patch	none
[Animated GIF] With patch applied	none

Matt Baker

Reported 2018-10-01 17:52:51 PDT

This only affects selected DOM breakpoints. The hovered appearance for the goto arrow for non-selected tree elements is fine.

Attachments
[Image] DOM breakpoint tree element (selected) (768.89 KB, image/png) 2018-10-01 17:54 PDT, Matt Baker	no flags	Details
[Image] DOM breakpoint tree element (hovered) (767.11 KB, image/png) 2018-10-01 17:55 PDT, Matt Baker	no flags	Details
Patch (1.26 KB, patch) 2018-10-12 12:58 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Animated GIF] With patch applied (20.50 KB, image/gif) 2018-10-12 13:00 PDT, Nikita Vasilyev	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-10-01 17:53:18 PDT

<rdar://problem/44927654>

Matt Baker

Comment 2 2018-10-01 17:54:54 PDT

Created attachment 351329 [details] [Image] DOM breakpoint tree element (selected) This isn't really the "breakpoint", it's the breakpoint's parent :P

Matt Baker

Comment 3 2018-10-01 17:55:53 PDT

Created attachment 351330 [details] [Image] DOM breakpoint tree element (hovered) Hovered style looks good!

Nikita Vasilyev

Comment 4 2018-10-12 12:58:24 PDT

Created attachment 352189 [details] Patch

Nikita Vasilyev

Comment 5 2018-10-12 13:00:08 PDT

Created attachment 352191 [details] [Animated GIF] With patch applied

Matt Baker

Comment 6 2018-10-12 14:03:07 PDT

Comment on attachment 352189 [details] Patch rs=me

WebKit Commit Bot

Comment 7 2018-10-12 14:30:24 PDT

Comment on attachment 352189 [details] Patch Clearing flags on attachment: 352189 Committed r237078: <https://trac.webkit.org/changeset/237078>

WebKit Commit Bot

Comment 8 2018-10-12 14:30:25 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.