Bug 190180 - Web Inspector: Dark Mode: wrong color used for "goto arrow" for selected DOM breakpoint tree element
Summary: Web Inspector: Dark Mode: wrong color used for "goto arrow" for selected DOM ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-01 17:52 PDT by Matt Baker
Modified: 2018-10-12 14:30 PDT (History)
3 users (show)

See Also:

Attachments
[Image] DOM breakpoint tree element (selected) (768.89 KB, image/png)
2018-10-01 17:54 PDT, Matt Baker 		no flags Details
[Image] DOM breakpoint tree element (hovered) (767.11 KB, image/png)
2018-10-01 17:55 PDT, Matt Baker 		no flags Details
Patch (1.26 KB, patch)
2018-10-12 12:58 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] With patch applied (20.50 KB, image/gif)
2018-10-12 13:00 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-10-01 17:52:51 PDT 
This only affects selected DOM breakpoints. The hovered appearance for the goto arrow for non-selected tree elements is fine.
Comment 1 Radar WebKit Bug Importer 2018-10-01 17:53:18 PDT 
<rdar://problem/44927654>
Comment 2 Matt Baker 2018-10-01 17:54:54 PDT 
Created attachment 351329 [details]
[Image] DOM breakpoint tree element (selected)

This isn't really the "breakpoint", it's the breakpoint's parent :P
Comment 3 Matt Baker 2018-10-01 17:55:53 PDT 
Created attachment 351330 [details]
[Image] DOM breakpoint tree element (hovered)

Hovered style looks good!
Comment 4 Nikita Vasilyev 2018-10-12 12:58:24 PDT 
Created attachment 352189 [details]
Patch
Comment 5 Nikita Vasilyev 2018-10-12 13:00:08 PDT 
Created attachment 352191 [details]
[Animated GIF] With patch applied
Comment 6 Matt Baker 2018-10-12 14:03:07 PDT 
Comment on attachment 352189 [details]
Patch

rs=me
Comment 7 WebKit Commit Bot 2018-10-12 14:30:24 PDT 
Comment on attachment 352189 [details]
Patch

Clearing flags on attachment: 352189

Committed r237078: <https://trac.webkit.org/changeset/237078>
Comment 8 WebKit Commit Bot 2018-10-12 14:30:25 PDT 
All reviewed patches have been landed.  Closing bug.