Bug 190173

Summary: Add support for MediaKeyEncryptionScheme
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jer Noble
Reported 2018-10-01 15:39:50 PDT
Add support for MediaKeyEncryptionScheme
Attachments
Patch (30.32 KB, patch)
2018-10-01 15:44 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.96 KB, patch)
2018-10-18 12:48 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-10-01 15:44:06 PDT
Created attachment 351316 [details] Patch
EWS Watchlist
Comment 2 2018-10-01 15:46:46 PDT
Attachment 351316 [details] did not pass style-queue: ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:33: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Radar WebKit Bug Importer
Comment 3 2018-10-01 16:08:44 PDT
<rdar://problem/44924613>
Jer Noble
Comment 4 2018-10-18 12:48:00 PDT
Created attachment 352717 [details] Patch for landing
EWS Watchlist
Comment 5 2018-10-18 12:49:43 PDT
Attachment 352717 [details] did not pass style-queue: ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:33: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/encryptedmedia/CDMEncryptionScheme.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 6 2018-10-18 14:44:33 PDT
Comment on attachment 352717 [details] Patch for landing Clearing flags on attachment: 352717 Committed r237268: <https://trac.webkit.org/changeset/237268>
WebKit Commit Bot
Comment 7 2018-10-18 14:44:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.