Bug 190170 – REGRESSION(r236624): Crash in PlaybackSessionInterfaceContext::isPictureInPictureSupportedChanged(bool) in WKTR

• Component: New Bugs
• Status: RESOLVED DUPLICATE

[Jer Noble]

REGRESSION(r236624): Crash in PlaybackSessionInterfaceContext::isPictureInPictureSupportedChanged(bool) in WKTR

[Jer Noble]

Created attachment 351314 [details]
Patch

[EWS Watchlist]

Comment on attachment 351314 [details]
Patch

Attachment 351314 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9419376

New failing tests:
media/range-extract-contents-crash.html

[EWS Watchlist]

Created attachment 351327 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Ryan Haddad]

(In reply to Build Bot from comment #2)
> Comment on attachment 351314 [details]
> Patch
> 
> Attachment 351314 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: https://webkit-queues.webkit.org/results/9419376
> 
> New failing tests:
> media/range-extract-contents-crash.html

Application Specific Information:
CRASHING TEST: media/range-extract-contents-crash.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   ???                           	000000000000000000 0 + 0
1   com.apple.WebKit              	0x000000010f83466d WebKit::PlaybackSessionModelContext::externalPlaybackChanged(bool, WebCore::PlaybackSessionModel::ExternalPlaybackTargetType, WTF::String const&) + 185 (Vector.h:1504)
2   com.apple.WebKit              	0x000000010f6dc46e void IPC::callMemberFunctionImpl<WebKit::PlaybackSessionManagerProxy, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String), std::__1::tuple<unsigned long long, bool, unsigned int, WTF::String>, 0ul, 1ul, 2ul, 3ul>(WebKit::PlaybackSessionManagerProxy*, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String), std::__1::tuple<unsigned long long, bool, unsigned int, WTF::String>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) + 66 (utility:753)
3   com.apple.WebKit              	0x000000010f6db401 void IPC::handleMessage<Messages::PlaybackSessionManagerProxy::ExternalPlaybackPropertiesChanged, WebKit::PlaybackSessionManagerProxy, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String)>(IPC::Decoder&, WebKit::PlaybackSessionManagerProxy*, void (WebKit::PlaybackSessionManagerProxy::*)(unsigned long long, bool, unsigned int, WTF::String)) + 73 (utility:753)
4   com.apple.WebKit              	0x000000010f6b6505 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 127 (MessageReceiverMap.cpp:123)
5   com.apple.WebKit              	0x000000010f8addbc WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 24 (WebProcessProxy.cpp:650)
6   com.apple.WebKit              	0x000000010f6a7606 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 108 (memory:2714)
7   com.apple.WebKit              	0x000000010f6aa259 IPC::Connection::dispatchIncomingMessages() + 833 (memory:2734)
8   com.apple.JavaScriptCore      	0x000000010e2e41f6 WTF::RunLoop::performWork() + 214 (Function.h:56)
9   com.apple.JavaScriptCore      	0x000000010e2e4512 WTF::RunLoop::performWork(void*) + 34 (RunLoopCF.cpp:39)
10  com.apple.CoreFoundation      	0x00007fff881703e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
11  com.apple.CoreFoundation      	0x00007fff8815165c __CFRunLoopDoSources0 + 556
12  com.apple.CoreFoundation      	0x00007fff88150b46 __CFRunLoopRun + 934
13  com.apple.CoreFoundation      	0x00007fff88150544 CFRunLoopRunSpecific + 420
14  com.apple.Foundation          	0x00007fff89b81252 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
15  WebKitTestRunner              	0x000000010e219261 WTR::TestController::platformRunUntil(bool&, WTF::Seconds) + 191 (TestControllerCocoa.mm:204)
16  WebKitTestRunner              	0x000000010e21a365 WTR::TestInvocation::invoke() + 305 (TestInvocation.cpp:179)
17  WebKitTestRunner              	0x000000010e20f931 WTR::TestController::runTest(char const*) + 2205 (TestController.cpp:1379)
18  WebKitTestRunner              	0x000000010e20fc92 WTR::TestController::runTestingServerLoop() + 132 (TestController.cpp:1408)
19  WebKitTestRunner              	0x000000010e20a084 WTR::TestController::TestController(int, char const**) + 310 (TestController.cpp:147)
20  WebKitTestRunner              	0x000000010e1f9d5c main + 657 (main.mm:68)
21  libdyld.dylib                 	0x00007fff9dd22235 start + 1

[Alex Christensen]

That test failure looks quite suspicious.

[Ryan Haddad]

The change that introduced the regression was rolled out in https://trac.webkit.org/changeset/236748/webkit.

*** This bug has been marked as a duplicate of bug 188747 ***