Bug 190168

Summary:

[WebVTT] Cue with line setting is not rendered correctly

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebCore Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, bfulgham, commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-sierra-wk2	none
Archive of layout-test-results from ews100 for mac-sierra	none
Patch	none
Patch	none

Per Arne Vollan

Reported 2018-10-01 15:03:13 PDT

When the line setting contains an optional alignment value, the cue is not rendered at the correct position, see https://w3c.github.io/webvtt/#webvtt-line-cue-setting.

Attachments
Patch (8.35 KB, patch) 2018-10-01 15:14 PDT, Per Arne Vollan	eric.carlson: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.06 MB, application/zip) 2018-10-01 17:32 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews100 for mac-sierra (2.70 MB, application/zip) 2018-10-01 18:15 PDT, EWS Watchlist	no flags	Details
Patch (8.74 KB, patch) 2018-10-02 09:25 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Patch (8.73 KB, patch) 2018-10-02 09:28 PDT, Per Arne Vollan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2018-10-01 15:14:03 PDT

Created attachment 351312 [details] Patch

Per Arne Vollan

Comment 2 2018-10-01 15:14:51 PDT

rdar://problem/44384699

EWS Watchlist

Comment 3 2018-10-01 17:32:38 PDT

Comment on attachment 351312 [details] Patch Attachment 351312 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9419303 New failing tests: media/track/track-cue-line-position.html

EWS Watchlist

Comment 4 2018-10-01 17:32:39 PDT

Created attachment 351326 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-10-01 18:15:50 PDT

Comment on attachment 351312 [details] Patch Attachment 351312 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9419729 New failing tests: media/track/track-cue-line-position.html

EWS Watchlist

Comment 6 2018-10-01 18:15:51 PDT

Created attachment 351332 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Eric Carlson

Comment 7 2018-10-02 01:54:17 PDT

Comment on attachment 351312 [details] Patch r=me once the bots are happy

Per Arne Vollan

Comment 8 2018-10-02 09:25:59 PDT

Created attachment 351397 [details] Patch

Per Arne Vollan

Comment 9 2018-10-02 09:28:40 PDT

Created attachment 351398 [details] Patch

Per Arne Vollan

Comment 10 2018-10-02 11:10:35 PDT

Comment on attachment 351398 [details] Patch Thanks for reviewing!