Bug 190158

Summary: Web Inspector: make the layers sidebar in the Elements tab always visible
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied none

Devin Rousso
Reported 2018-10-01 14:23:19 PDT
Instead of removing the Layers sidebar when the Layers tab is enabled, we should always show the Layers sidebar. There is still utility in showing layer information for a specific node. The Layers tab is more for a page-level visualization.
Attachments
Patch (2.84 KB, patch)
2018-10-25 10:38 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (1.30 MB, image/png)
2018-10-25 10:38 PDT, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-25 10:38:10 PDT
Created attachment 353092 [details] Patch
Devin Rousso
Comment 2 2018-10-25 10:38:37 PDT
Created attachment 353093 [details] [Image] After Patch is applied
Ross Kirsling
Comment 3 2018-10-25 13:14:18 PDT
Seems good as long as nobody's worried about the Layers sidebar not being the exactly the same as the Layers tab sidebar. (It is, after all, quite possible that I was the only one ever worried about that... 😅)
Blaze Burg
Comment 4 2018-10-30 12:53:11 PDT
Comment on attachment 353092 [details] Patch r=me In the short term this seems fine, as Layers tab still has some key functionality missing. In the longer term I think a context menu action per-node would be sufficient for localizing a node's layer.
Ross Kirsling
Comment 5 2018-10-30 13:04:29 PDT
(In reply to Brian Burg from comment #4) > ... In the longer term I think a context menu action > per-node would be sufficient for localizing a node's layer. We do have that thanks to Devin's earlier work :) https://bugs.webkit.org/show_bug.cgi?id=181800
WebKit Commit Bot
Comment 6 2018-10-30 13:23:53 PDT
Comment on attachment 353092 [details] Patch Clearing flags on attachment: 353092 Committed r237599: <https://trac.webkit.org/changeset/237599>
WebKit Commit Bot
Comment 7 2018-10-30 13:23:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-10-30 13:53:21 PDT
<rdar://problem/45679555>
Note You need to log in before you can comment on or make changes to this bug.