Bug 190157

Summary: Don't read from WebCore's bundle for IDNScriptWhiteList
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Description Alex Christensen 2018-10-01 14:21:56 PDT
Don't read from a file for IDNScriptWhiteList
Comment 1 Alex Christensen 2018-10-01 14:23:22 PDT
Created attachment 351298 [details]
Patch
Comment 2 Alex Christensen 2018-10-01 14:50:38 PDT
Created attachment 351307 [details]
Patch
Comment 3 mitz 2018-10-01 15:54:06 PDT
Comment on attachment 351307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351307&action=review

> Source/WebCore/ChangeLog:8
> +        No change in behavior.  This increases performance by not reading from a file,

Can you explain how the behavior where if a whitelist is placed in /Library or ~/Library, its contents is used instead of the built-in list is maintained with this change?
Comment 4 Alex Christensen 2018-10-01 16:08:13 PDT
Created attachment 351319 [details]
Patch
Comment 5 Alex Christensen 2018-10-01 17:21:26 PDT
http://trac.webkit.org/r236703
Comment 6 Radar WebKit Bug Importer 2018-10-01 17:22:23 PDT
<rdar://problem/44926790>