Bug 190131

Summary: [JSC] Add a JSONStringify overload that receives a JSValue space
Product: WebKit Reporter: Koby <koby.b>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189947    
Attachments:
Description Flags
Patch none

Koby
Reported 2018-10-01 05:52:21 PDT
Hi, In node-jsc, I neede to be able to pass a JSValue space to JSONStringify, not just the number of spaces to use. This patch add that overload to JSONStringify. Regarding tests, I wasn't sure there are c++ tests to JSONStringify or where should I add them. So for now I didn't add new tests. Thanks Koby
Attachments
Patch (2.44 KB, patch)
2018-10-01 05:55 PDT, Koby 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Koby
Comment 1 2018-10-01 05:55:43 PDT
Created attachment 351238 [details] Patch
Yusuke Suzuki
Comment 2 2018-10-01 06:55:27 PDT
Comment on attachment 351238 [details] Patch r=me
Yusuke Suzuki
Comment 3 2018-10-01 07:46:35 PDT
Comment on attachment 351238 [details] Patch BTW, you can request both flags at the same time (r? and cq?).
WebKit Commit Bot
Comment 4 2018-10-01 08:12:32 PDT
Comment on attachment 351238 [details] Patch Clearing flags on attachment: 351238 Committed r236660: <https://trac.webkit.org/changeset/236660>
WebKit Commit Bot
Comment 5 2018-10-01 08:12:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-01 08:13:25 PDT
<rdar://problem/44908757>
Koby
Comment 7 2018-10-01 10:28:19 PDT
@Yusuke thanks, I thought I had to wait for the review before settings the cq? flag.
Note You need to log in before you can comment on or make changes to this bug.