Bug 190125 – [MSE][GStreamer] Set a minimum sample duration

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Alicia Boya García]

The last sample of the audio track in the asset used in this test player has a tiny duration (100 ns):

http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism/Manifest

So small, we are truncating it to zero. We're not supposed to have frames with zero duration an. Instead, lets set a minimum frame duration for those fringe cases.

[Alicia Boya García]

Created attachment 351251 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 351251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351251&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:59
> +        m_duration = createMediaTime(std::max(GST_BUFFER_DURATION(buffer), minimumDuration));

I'd recommend moving this above to a more prominent position than inside this method.

[Alicia Boya García]

Created attachment 351270 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 351270 [details]
Patch

Clearing flags on attachment: 351270

Committed r236679: <https://trac.webkit.org/changeset/236679>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.