| Summary: | Optimize RenderStyle::diff() and clean up the code | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | ews-watchlist, koivisto, mitz, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Simon Fraser (smfr)
2018-09-28 18:15:56 PDT
Created attachment 351154 [details]
Patch
Created attachment 351166 [details]
Patch
>Optimize RenderStyle::diff() and clean up the code
Do you mind splitting it into multiple patches? I find it difficult to review this (unless someone else is willing to r+it as it is)
Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9390801 New failing tests: fast/table/correct-baseline-after-style-change.html Created attachment 351170 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9390812 New failing tests: fast/table/correct-baseline-after-style-change.html Created attachment 351171 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9390916 New failing tests: fast/table/correct-baseline-after-style-change.html Created attachment 351172 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9390878 New failing tests: fast/table/correct-baseline-after-style-change.html Created attachment 351173 [details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 351166 [details] Patch Attachment 351166 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9391705 New failing tests: fast/table/correct-baseline-after-style-change.html Created attachment 351176 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 351180 [details]
Patch
Created attachment 351181 [details]
RenderStyle.cpp for ease of review
Comment on attachment 351180 [details] Patch Attachment 351180 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9395204 New failing tests: fast/workers/worker-exception-during-navigation.html Created attachment 351192 [details]
Archive of layout-test-results from ews203 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 351180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351180&action=review > Source/WebCore/ChangeLog:10 > + To reduce the changes of future changes regressing this, move code comparing values the chances |