Bug 190095

Summary: REGRESSION(r236609): API tests for mso list preservation are failing
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug wenson_hsieh: review+

Description Ryosuke Niwa 2018-09-28 15:18:58 PDT
e.g.
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/8288/steps/run-api-tests/logs/stdio


TestWebKitAPI.PasteWebArchive.ExposesHTMLTypeInDataTransfer Passed

    
    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:123
    Value of: [webView stringByEvaluatingJavaScript:@"pastedHTML.includes('<style class=\"WebKit-mso-list-quirks-style\">\\n<!--\\n')"].boolValue
      Actual: false
    Expected: true

...
 
    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:144
    Value of: [webView stringByEvaluatingJavaScript:@"htmlInDataTransfer.includes('[endif]')"].boolValue
      Actual: false
    Expected: true
    
TestWebKitAPI.PasteWebArchive.PreservesMSOList Failed

    
    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:174
    Value of: [webView stringByEvaluatingJavaScript:@"pastedHTML.includes('<style class=\"WebKit-mso-list-quirks-style\">\\n<!--\\n')"].boolValue
      Actual: false
    Expected: true

...

    /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:191
    Value of: [webView stringByEvaluatingJavaScript:@"htmlInDataTransfer.includes('[endif]')"].boolValue
      Actual: false
    Expected: true
    
TestWebKitAPI.PasteWebArchive.PreservesMSOListInCompatibilityMode Failed
Comment 1 Radar WebKit Bug Importer 2018-09-28 15:25:17 PDT
<rdar://problem/44876754>
Comment 2 Ryosuke Niwa 2018-09-28 15:26:45 PDT
Created attachment 351119 [details]
Fixes the bug
Comment 3 Ryosuke Niwa 2018-09-28 15:32:58 PDT
Committed r236618: <https://trac.webkit.org/changeset/236618>