Bug 190091

Summary: Unify implementation in VideoFullscreenInterfaceAVKit
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 190207    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing. none

Jeremy Jones
Reported 2018-09-28 14:28:49 PDT
Unify implementation in VideoFullscreenInterfaceAVKit
Attachments
Patch (30.79 KB, patch)
2018-09-28 14:29 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch (33.45 KB, patch)
2018-09-28 14:32 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Patch for landing. (32.83 KB, patch)
2018-09-30 17:58 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2018-09-28 14:29:21 PDT
Created attachment 351111 [details] Patch
Jeremy Jones
Comment 2 2018-09-28 14:32:04 PDT
Created attachment 351113 [details] Patch
Jeremy Jones
Comment 3 2018-09-28 14:32:35 PDT
rdar://problem/44734523
Jeremy Jones
Comment 4 2018-09-30 17:58:18 PDT
Created attachment 351220 [details] Patch for landing.
WebKit Commit Bot
Comment 5 2018-10-01 11:00:05 PDT
Comment on attachment 351220 [details] Patch for landing. Clearing flags on attachment: 351220 Committed r236671: <https://trac.webkit.org/changeset/236671>
Ryan Haddad
Comment 6 2018-10-02 10:11:23 PDT
This was rolled out in https://trac.webkit.org/changeset/236748/webkit because it depended upon https://trac.webkit.org/changeset/236624/webkit, which was rolled out due to test regressions.
Jeremy Jones
Comment 7 2018-10-04 16:27:23 PDT
Patch that necessitated the rebased "patch for landing" has been rolled out, taking this patch with it. So I'm re-submitting the original patch, pre-rebase.
WebKit Commit Bot
Comment 8 2018-10-04 16:52:46 PDT
Comment on attachment 351113 [details] Patch Clearing flags on attachment: 351113 Committed r236860: <https://trac.webkit.org/changeset/236860>
WebKit Commit Bot
Comment 9 2018-10-04 16:52:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.