Bug 190077

Summary: Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2018-09-28 09:26:13 PDT
Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
Attachments
Patch (2.89 KB, patch)
2018-09-28 09:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-09-28 09:26:29 PDT
<rdar://problem/44812613>
Chris Dumez
Comment 2 2018-09-28 09:29:43 PDT
Created attachment 351084 [details] Patch
Simon Fraser (smfr)
Comment 3 2018-09-28 09:58:21 PDT
Comment on attachment 351084 [details] Patch Did we look at internal SVN history to see why this was added?
Chris Dumez
Comment 4 2018-09-28 10:01:33 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 351084 [details] > Patch > > Did we look at internal SVN history to see why this was added? I haven't because I did not know this was a thing. I tried to git blame and did not find anything useful.
WebKit Commit Bot
Comment 5 2018-09-28 10:04:12 PDT
Comment on attachment 351084 [details] Patch Clearing flags on attachment: 351084 Committed r236600: <https://trac.webkit.org/changeset/236600>
WebKit Commit Bot
Comment 6 2018-09-28 10:04:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.